Propagate TUS upload body errors and close file handles#182
Closed
zerox80 wants to merge 1 commit into
Closed
Conversation
- propagate request body read failures during TUS uploads so OkHttp can abort and the server (tusd writeChunk) returns a meaningful error instead of treating a partial body as success - close the file handle used for creation-with-upload after the request completes (the previous code opened a RandomAccessFile and never closed it, leaking file descriptors and blocking file deletion on Windows) - refactor CreateTusUploadRemoteOperation.run for readability (LongMethod detekt) - add tests for body error propagation, file handle cleanup, and the creation-only path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate request body read failures during TUS uploads so OkHttp can abort the request and the server (tusd writeChunk) returns a meaningful error instead of treating a partial body as success. Previously, exceptions raised while streaming the request body were silently logged, leaving the client to believe the upload completed correctly.
Close the file handle used for creation-with-upload after the request completes. The previous code opened a RandomAccessFile and never closed it, leaking file descriptors and blocking file deletion on Windows.
Refactor CreateTusUploadRemoteOperation.run for readability (LongMethod detekt).
Add tests for body error propagation, file handle cleanup, and the creation-only path.