fix(telemetry): refresh public vocabulary from released metadata - #28
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 1, 2026, 2:45 AM ET / 06:45 UTC (Revision 2). ClawSweeper reviewWhat this changesRefresh the telemetry receiver’s public-name vocabulary from released OpenClaw metadata and add a CI check for releases without a reviewed snapshot. Merge readiness✅ Ready for maintainer review This refresh remains necessary: current main still excludes the newly documented public names. Exact-head checks pass, rebase continuity is verified, and no actionable patch defect was found. Priority: P2 Review scores
Verification
How this fits togetherThe telemetry receiver filters optional feature reports through a compiled list of public names before recording analytics. The generator derives that list from reviewed OpenClaw packaging metadata, provider declarations, and official catalogs. flowchart TD
A[Released OpenClaw metadata] --> B[Snapshot generator]
B --> C[Reviewed retained snapshots]
C --> D[Compiled public vocabulary]
E[Optional feature reports] --> F[Validate and filter names]
D --> F
F --> G[Analytics records]
H[Latest release check] --> C
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep public-name admission based on reviewed immutable snapshots, preserve historical names, and detect release drift through the existing CI workflow. Do we have a high-confidence way to reproduce the issue? Yes, from source: main’s compiled vocabulary omits the named public plugins, and the existing parser filters those names out before analytics serialization. No runtime reproduction was executed during this read-only review. Is this the best way to solve the issue? Yes. Extending the existing retained snapshots and adapting their generator is a narrow repair that preserves historical admission and avoids runtime discovery. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 23066fd08500. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
d7831a8 to
c2dd913
Compare
|
@clawsweeper re-review Please review exact head |
|
🦞👀 Re-review progress:
|
What Problem This Solves
The receiver's public vocabulary was last refreshed on September 7. Released public plugins such as
github,code-mode-quickjs, andsession-shareare therefore discarded before storage even when clients correctly report them.Why This Change Was Made
Refresh from OpenClaw
v2026.9.7, resolved to immutable commitc074824a27c96d3983043f9eeb33823cd1772d8c, using the canonical packaging helper, public provider declarations, and retained official catalog history. Add 14 verified public names (188 to 202), preserve the previous snapshot unchanged, and adapt the generator to the release's relocated provider metadata and shared packaging policy.On existing CI runs, resolve the latest published OpenClaw release tag to its commit and require a reviewed vocabulary snapshot. This detects release drift independently of generated-file consistency; it never refreshes or admits names automatically. Lookup failures fail the check.
User Impact
Public names from the reviewed release can be retained. Unknown and private names remain excluded. Collection policy, consent, identifiers, storage columns, and deployment configuration are unchanged. Previously discarded names cannot be reconstructed.
Evidence
git diff --checkpasses. Historical CI passes ond7831a8f32fd3a82558badff8d9978028188c470: typecheck, 494 tests across 13 files, release freshness, and Wrangler dry-run. That deployment job was skipped. Independent source review found no blockers for that head.Production generator/generated-source LOC: +35/-2 (net +33). The increase supports the released metadata contract and independent release freshness check; tests are +63/-2, immutable provenance metadata +314 lines, CI +7 lines.
Rebased onto the merged list-truncation fix at
23066fd08500d146d79a1d0b205443b3c30aae6a. Both changelog entries are retained; the generator, metadata, generated source, tests, and CI workflow are byte-identical to the earlier reviewed head. Syntax, workflow lint, retained-union, and diff checks pass. Fresh exact-head CI and review are pending onc2dd9130f6157ab8b561e261d1ee185daad46f0f.Merging to main uses the existing deployment workflow. No production ingestion probe is included.