fix(brew): remove silent cask-to-formula fallback in retry path#104
Merged
Conversation
installSmartCaskWithError silently tried `brew install <pkg>` (formula) when `brew install --cask <pkg>` failed. If the formula succeeded the caller reported "retry succeeded" and appended to installedCasks — the user never knew a different package type was installed. Remove the formula fallback so a cask failure is reported as a failure. The hint-based fallback in installFormulaWithError (where brew itself says "try again using --cask") is left intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installSmartCaskWithErrorsilently triedbrew install <pkg>(formula) whenbrew install --cask <pkg>failed. If the formula install succeeded, the function returned success and the caller appended the package toinstalledCasks— the user never knew a different package type was installed (e.g. docker CLI instead of Docker Desktop).installFormulaWithError(where brew itself suggests "try again using --cask") is left intact — that one is correct.Test plan
TestInstallSmartCask_NeverFallsBackToFormula— cask failure returns an error, does not silently succeedTestInstallSmartCask_RetriesOnTransientError— transient errors still retry up to 3 times, succeed when the error clearsgo test ./internal/...)