Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/openai/_qs.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,9 @@ def _stringify_item(
f"Unknown array_format value: {array_format}, choose from {', '.join(get_args(ArrayFormat))}"
)

serialised = self._primitive_value_to_str(value)
if not serialised:
if value is None:
return []
return [(key, serialised)]
return [(key, self._primitive_value_to_str(value))]

def _primitive_value_to_str(self, value: PrimitiveData) -> str:
# copied from httpx
Expand Down
19 changes: 19 additions & 0 deletions tests/test_qs_empty_values.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
from urllib.parse import unquote

from openai._qs import stringify


def test_empty_string_scalar_is_preserved() -> None:
assert stringify({"filter": ""}) == "filter="


def test_none_scalar_is_still_omitted() -> None:
assert stringify({"filter": None}) == ""


def test_nested_empty_string_is_preserved() -> None:
assert unquote(stringify({"filter": {"name": ""}})) == "filter[name]="


def test_empty_string_in_repeat_array_is_preserved() -> None:
assert stringify({"filter": ["", "active"]}) == "filter=&filter=active"