fix(helpers): use running loop in voice helpers - #3807
Open
Ghraven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The voice helper async methods are already running inside coroutines, but they call
asyncio.get_event_loop()before using the loop for thread-safe callbacks and executor work. On modern Python,asyncio.get_running_loop()is the clearer API in this context and avoids depending on event-loop policy fallback behavior.Before / after
Before,
Microphone.record(),LocalAudioPlayer.play(), andLocalAudioPlayer.play_stream()fetched the event loop withget_event_loop().After, those async methods capture the currently running loop with
get_running_loop()while keeping the existingcall_soon_threadsafe()andrun_in_executor()behavior unchanged.Verification
python -m py_compile src/openai/helpers/microphone.py src/openai/helpers/local_audio_player.pygit diff --checkI did not run a hardware audio smoke test locally.