feat(auth): harden X.509 lifecycle and add end-to-end validation - #938
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 63 mixed files remain; 0 existing customizations changed. Compared 63 existing customizations unchanged
23 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32915067605 --repo openai/openai-java \
--name castiron-custom-code-32915067605-1 --dir /tmp/castiron-custom-code-32915067605-1
git apply --stat /tmp/castiron-custom-code-32915067605-1/custom-code.patch
cat /tmp/castiron-custom-code-32915067605-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 9a3ac279fa8a56edc9df884f923c777707c105c7 54f37cdf251ffdebf447cc4295203c1a30c75097
python3 scripts/castiron/custom_code_report.py report \
--base 9a3ac279fa8a56edc9df884f923c777707c105c7 \
--head 54f37cdf251ffdebf447cc4295203c1a30c75097 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-54f37cdf251f
cat /tmp/castiron-custom-code-54f37cdf251f/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Found two actionable issues in the new X.509 lifecycle: permanent issuer TLS failures can be masked by cached-token fallback, and repeatable request bodies are closed before 401 replay/retries. Details are inline.
9603588 to
90412a6
Compare
3bec62a to
6a0d664
Compare
90412a6 to
9a3ac27
Compare
6a0d664 to
54f37cd
Compare
647a821
into
codex/x509-java-04-client-integration
Summary
Unitendpoints, and raw-response continuationsCompatibility and security boundaries
Validation
scripts/testgraph with Steady: passed, including R8 and ProGuard artifactsgit diff --check: passed1e5bba26e91a638915bfa509e87adee10b598c5d92bd23ae54a98a504a4e9fe6)Stack
Stacked on #936.