feat(api): support backend-mediated Realtime WebRTC calls - #937
Conversation
Castiron-Internal-PR: openai/openai-java-internal#49 Castiron-Source-SHA: b14df18425c937f604f2442e2bbb6c8af18d733b Castiron-Public-Base-SHA: 3c63360
Castiron custom code✅ No new custom-code files detected. 53 mixed files remain; 0 existing customizations changed. Compared 53 existing customizations unchanged
13 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32891187028 --repo openai/openai-java \
--name castiron-custom-code-32891187028-1 --dir /tmp/castiron-custom-code-32891187028-1
git apply --stat /tmp/castiron-custom-code-32891187028-1/custom-code.patch
cat /tmp/castiron-custom-code-32891187028-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 3c63360e04f6873a2386860ce0ac0ef3a783e955 ce510974a425bcc16b22c87fbf7c06948ded82ca
python3 scripts/castiron/custom_code_report.py report \
--base 3c63360e04f6873a2386860ce0ac0ef3a783e955 \
--head ce510974a425bcc16b22c87fbf7c06948ded82ca --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-ce510974a425
cat /tmp/castiron-custom-code-ce510974a425/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed both blocking and async Realtime call generation. Project-key requests correctly remain typed multipart even when optional session is omitted; SDP/JSON part media types, omission/null handling, repeatable request bodies, bearer authentication, and full closeable HttpResponse/Location headers are preserved. WireMock, API compatibility, Java version, security, and generation checks are green. Approved.
Summary
Add Realtime call creation to the blocking and asynchronous clients so server-side applications can exchange an SDP offer and optional session configuration for an SDP answer.
This removes the need for a handwritten HTTP request for WebRTC signaling. The new operation preserves the API’s SDP and JSON content types and returns the SDP answer through
HttpResponse.