Skip to content

fix: mark realtime session as closed before CancelledError on cycle detection #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AAliKKhan wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Draft

fix: mark realtime session as closed before CancelledError on cycle detection #3926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/agents/realtime/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,8 @@ async def close(self) -> None:
if cleanup_task is not None and (
current_task in self._guardrail_tasks or current_task in self._tool_call_tasks
):
# Cleanup is already waiting for this tracked task, so waiting here would form a cycle.
self._closing = True
self._closed = True

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid marking the session closed before cleanup finishes

When a cancelled guardrail/tool task re-enters close() while _cleanup_task is active, this marks _closed before _cleanup has finished cancelling background work and closing the model. Any other close() call in that window returns immediately without waiting, and if model.close() later fails the retry path is disabled because _closed remains true, leaving the transport unclosed. Keep this path as in-progress and let _cleanup mark the session closed after resources are coherent. .agents/references/realtime-session-lifecycle.mdL25-L26

Useful? React with 👍 / 👎.

raise asyncio.CancelledError

if cleanup_task is None:
Expand Down