fix: prevent list aliasing in _populate_state_from_result#3924
Open
AAliKKhan wants to merge 1 commit into
Open
fix: prevent list aliasing in _populate_state_from_result#3924AAliKKhan wants to merge 1 commit into
AAliKKhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In _populate_state_from_result, when _model_input_items is not set on the result, state._generated_items was assigned a bare reference to result.new_items instead of a copy. Since state._generated_items can be mutated (e.g., appending items during interruption approval), this silently corrupted result.new_items — the primary public API for consuming agent output. The fix makes a defensive copy via list().