fix: remove redundant deep copy in input preprocessing#3922
Open
AAliKKhan wants to merge 1 commit into
Open
Conversation
seratch
requested changes
Jul 23, 2026
seratch
left a comment
Member
There was a problem hiding this comment.
Thanks for the optimization. ItemHelpers.input_to_new_input_list() already recursively materializes list inputs, so removing the second conversion is appropriate. However, test_responses_materializes_iterator_payload currently monkeypatches that helper to return an unmaterialized iterable and therefore depends on the conversion this PR removes. Please update the test to pass the nested iterable through the real ItemHelpers.input_to_new_input_list() implementation, while preserving the assertions that input and tool iterables are materialized exactly once. Once that existing regression coverage passes, this should be ready for another review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ItemHelpers.input_to_new_input_list() already calls _to_dump_compatible() internally (items.py:772). The caller in OpenAIResponsesModel._create_request() was calling it a second time, creating an unnecessary deep copy of the entire input history on every model turn. For multi-turn conversations with large histories this doubles memory and CPU overhead.