fix(plugin): refresh changed bundled plugin contents - #527
Conversation
|
@codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
zcrab-oai
left a comment
There was a problem hiding this comment.
Reviewed managed-package-root forwarding, synchronized bundle revisions and real cached-plugin upgrades, Windows executable resolution, and the revised fix-finding safeguards.
ianw-oai
changed the title
|
@codex review Please review the current head, |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08c01ec8a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Resolve the MCP environment and cached-plugin test conflicts, retain current launcher behavior, and assign the changed bundle a fresh identity.
|
@codex review Please review exact head |
|
@codex security review Please review exact head |
mldangelo-oai
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
Summary
Give the changed bundled plugin a new identity so cached SDK installs receive the current payload. Keep the fix-finding guidance concise while preserving its independent investigation and patch-review steps.
Changes
0.1.22to0.1.23.0.1.22installation upgrades without losing stored credentials.main.Testing
Checks on
e70df1bf467fba5cf97ae2a0729e08633ee55686:pnpm run types,pnpm run format, andpnpm run build: passed.--seed 527): 1,581 passed, 30 platform tests skipped, 0 failed across 89 files.pnpm packand the installed-package checker: passed. The tarball contains 255 entries and the smoke test verified the public import, NodeNext types, CLI, 111 bundled plugin files, bundled Codex, and a nested worker without a global Codex executable.Native Windows end-to-end execution remains delegated to CI. Hosted checks were not awaited before moving to the next PR.
Risk and rollout
The bundled-plugin version change refreshes cached contents when this SDK package is next installed and run. It does not publish a package or deploy anything. Explicit executable overrides retain precedence, and the upgrade regression verifies that stored credentials survive.
Public disclosure review
An existing automated review artifact contains a requester-only report link. The link and identifier are not reproduced here. The second attestation remains unchecked because that artifact is already part of the public PR history.