Skip to content

refactor(workbench): remove duplicate migration relocation #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mldangelo-oai merged 1 commit into from
Aug 14, 2026
+1 −20
Merged

refactor(workbench): remove duplicate migration relocation #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions sdk/typescript/_bundled_plugin/scripts/workbench_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,17 +744,13 @@ def normalize_pre_release_execution_profile_migrations(
12: "scan continuation threads",
}
model_migration_name = "persist scan model settings"
warnings_migration_name = "persist scan completion warnings"
if execution_migrations.get(25) == "dynamic scan execution profiles":
connection.execute(
"UPDATE schema_migrations SET name = ? WHERE version = 25 AND name = ?",
(model_migration_name, "dynamic scan execution profiles"),
)
execution_migrations[25] = model_migration_name
has_legacy_profile_history = execution_migrations.get(11) == legacy_names[11]
has_public_warnings_history = (
execution_migrations.get(25) == warnings_migration_name
)

scan_columns = {
row["name"] for row in connection.execute("PRAGMA table_info(scans)")
Expand All @@ -765,11 +761,7 @@ def normalize_pre_release_execution_profile_migrations(
has_legacy_profile_columns = (
"execution_model" in scan_columns or "execution_model" in workspace_columns
)
if not (
has_legacy_profile_history
or has_public_warnings_history
or has_legacy_profile_columns
):
if not (has_legacy_profile_history or has_legacy_profile_columns):
return

if (
Expand Down Expand Up @@ -811,17 +803,6 @@ def normalize_pre_release_execution_profile_migrations(
"The Codex Security database has an unsupported execution-profile migration history."
)

if has_public_warnings_history:
if execution_migrations.get(26) is not None:
raise SystemExit(
"The Codex Security database has an unsupported pre-release migration history."
)
connection.execute(
"UPDATE schema_migrations SET version = 26 WHERE version = 25 AND name = ?",
(warnings_migration_name,),
)
execution_migrations.pop(25)

if execution_migrations.get(25) not in (None, model_migration_name):
raise SystemExit(
"The Codex Security database has an unsupported execution-profile migration history."
Expand Down
Loading