Skip to content

refactor(release): remove unreachable DER parser guards #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mldangelo-oai merged 1 commit into from
Aug 14, 2026
+0 −12
Merged

refactor(release): remove unreachable DER parser guards #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions sdk/typescript/scripts/release-automation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,9 @@ function derChildren(bytes, element) {
let cursor = element.start;
while (cursor < element.end) {
const child = derElement(bytes, cursor, element.end);
if (child.end <= cursor) {
throw invalidSigningCertificate();
}
children.push(child);
cursor = child.end;
}
if (cursor !== element.end) {
throw invalidSigningCertificate();
}
return children;
}

Expand Down
6 changes: 0 additions & 6 deletions sdk/typescript/tests-ts/release-automation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,12 +992,6 @@ describe("cryptographically verified npm provenance", () => {
}
});

test("fails closed when a certificate child does not advance", () => {
expect(readFileSync(automationScript, "utf8")).toMatch(
/const child = derElement\(bytes, cursor, element\.end\);\s*if \(child\.end <= cursor\) \{\s*throw invalidSigningCertificate\(\);\s*\}/u,
);
});

test("rejects empty and noncanonical DER signing certificates", () => {
const invalidCertificates = [
Buffer.from([0x30, 0x00]),
Expand Down
Loading