test: remove duplicate launcher and runtime coverage - #398
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Removes duplicate integration tests while retaining launcher, Windows junction, and trusted-owner coverage.
Summary
Remove duplicate SDK integration tests without dropping their behavioral assertions.
Changes
Testing
bun test tests-ts/cli.test.ts tests-ts/cli-launcher.test.ts tests-ts/runtime.test.ts --timeout 30000— passed.pnpm run types— passed.prettier --check tests-ts/cli.test.ts tests-ts/cli-launcher.test.ts tests-ts/runtime.test.ts— passed.git diff --check— passed.Risk and rollout
Production code is unchanged. The retained launcher test includes Windows junction handling, installed-bin execution, startup failure handling, and the migrated compiler-stderr assertion. The remaining owner test preserves every user-ID and permission case.
Public disclosure review