ci: remove redundant package builds and unreachable setup - #397
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Removes redundant builds and unreachable setup while preserving package prepack builds and Windows security coverage.
Summary
Avoid repeated package builds and remove Windows-only setup from a job that never runs on Windows.
Changes
prepackbuild in Node CI, release verification, and Docker packaging.Testing
bun test tests-ts/release-automation.test.ts tests-ts/package-provenance.test.ts --timeout 30000— 196 passed.pnpm pack --pack-destination /private/tmp/codex-security-cleanup-tools/package-pr3— confirmedprepackbuilds the package.npm_config_cache=/private/tmp/codex-security-cleanup-tools/npm-cache node scripts/check-package.mjs /private/tmp/codex-security-cleanup-tools/package-pr3/openai-codex-security-0.1.11.tgz— passed.prettier --check ../../.github/workflows/node-ci.yml ../../.github/workflows/node-release.yml— passed.git diff --check— passed.Risk and rollout
Packaging still builds through the package's existing
prepackhook. Existing type checks, package inspection, installed-package smoke tests, release provenance, container checks, and real Windows security setup remain intact.Public disclosure review