Skip to content

ci: remove redundant package builds and unreachable setup - #397

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-redundant-ci-builds
Aug 14, 2026
Merged

ci: remove redundant package builds and unreachable setup#397
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-redundant-ci-builds

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Avoid repeated package builds and remove Windows-only setup from a job that never runs on Windows.

Changes

  • Rely on the existing prepack build in Node CI, release verification, and Docker packaging.
  • Remove unreachable Windows setup from the Ubuntu/macOS test matrix.
  • Preserve the actual Windows job's private temporary directory and security policy configuration.

Testing

  • bun test tests-ts/release-automation.test.ts tests-ts/package-provenance.test.ts --timeout 30000 — 196 passed.
  • pnpm pack --pack-destination /private/tmp/codex-security-cleanup-tools/package-pr3 — confirmed prepack builds the package.
  • npm_config_cache=/private/tmp/codex-security-cleanup-tools/npm-cache node scripts/check-package.mjs /private/tmp/codex-security-cleanup-tools/package-pr3/openai-codex-security-0.1.11.tgz — passed.
  • prettier --check ../../.github/workflows/node-ci.yml ../../.github/workflows/node-release.yml — passed.
  • git diff --check — passed.

Risk and rollout

Packaging still builds through the package's existing prepack hook. Existing type checks, package inspection, installed-package smoke tests, release provenance, container checks, and real Windows security setup remain intact.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 77663356a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 77663356a5

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Removes redundant builds and unreachable setup while preserving package prepack builds and Windows security coverage.

@mldangelo-oai
mldangelo-oai merged commit 1410919 into main Aug 14, 2026
55 of 58 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/remove-redundant-ci-builds branch August 14, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants