fix(sdk): warn when repository HEAD drifts - #360
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mr-Neutr0n <harikp2002@gmail.com>
ting-hong-shieh
approved these changes
Aug 14, 2026
ting-hong-shieh
left a comment
There was a problem hiding this comment.
Reviewed at eae65c543150f3dfe1040de1a6a7fcad07801fda. The monitor is limited to mutable Git targets, warns once, treats transient HEAD-read failures as non-fatal, and leaves completion-time target validation authoritative.
Validation snapshot:
- Exact head:
target-drift.test.ts2/2; focused orchestration test 1/1;pnpm lint;pnpm format. - Synthetic merge onto current
main(2f785900d2cefb932cf97fb1d675491d14790839): clean merge; the same three focused tests, typecheck, formatting, andgit diff --checkpass. - The broader API run is not part of this approval evidence: its five failures are host-environment failures under macOS
/usr/bin/python33.9, while the focused exact-head and current-main checks above are clean.
No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_changedwarning detailsFixes #164.
Verification
pnpm run typespasses/usr/bin/python3is Python 3.9 and the host Node is v25, outside the repository test matrix