Repository navigation
01a117b8 - Filter map places by country, shop, blockchain, and asset - #7
Conversation
GET /map/places applies a stored country, a shop name, and one blockchain and asset pair in SQL before the limit. GET /map/filters lists those values. Existing pins keep a null country until a real value is written.
|
EN: DE: DetailsHead: Lane Final result: {
"schema": "a38-review/v2",
"head": "42890faefdd94da22c873bfcc6512e5e9b4a92bc",
"passes": 1,
"defects": 0,
"set_aside": "none",
"lanes": [
{"id": "conformity-a", "result": "pass", "status": "complete", "provider": "grok", "model": "grok-4.6", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."},
{"id": "logic-a", "result": "pass", "status": "complete", "provider": "grok", "model": "grok-4.6", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for logical correctness."}
]
}The clean pair is the first review of this head. Country stays a stored column, shop names stay unset until written, and a blockchain plus an asset must match one support row before the limit is applied. |
A blockchain and asset filter matches one support row, and deleting a pin leaves a different asset on the same chain in place.
|
EN: DE: DetailsHead: Lane Lane Final result: {
"schema": "a38-review/v2",
"head": "2afcc89303cd9831ef68f203adb5ce0dfd520c57",
"passes": 1,
"defects": 0,
"set_aside": "none",
"lanes": [
{
"id": "conformity-a",
"result": "pass",
"status": "complete",
"provider": "grok",
"model": "grok-4.6",
"model_number": "grok-4.6",
"prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."
},
{
"id": "logic-a",
"result": "pass",
"status": "complete",
"provider": "grok",
"model": "grok-4.6",
"model_number": "grok-4.6",
"prompt": "Review the complete PR diff for logical correctness."
}
]
}Pass 1 on this head found no defects. |
|
EN: DE: DetailsHead: Lane Lane Final result: {
"schema": "a38-review/v2",
"head": "2afcc89303cd9831ef68f203adb5ce0dfd520c57",
"passes": 1,
"defects": 0,
"set_aside": "none",
"lanes": [
{
"id": "conformity-b",
"result": "pass",
"status": "complete",
"provider": "openai",
"model": "gpt-5.6-sol",
"model_number": "gpt-5.6-sol",
"prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."
},
{
"id": "logic-b",
"result": "pass",
"status": "complete",
"provider": "openai",
"model": "gpt-5.6-sol",
"model_number": "gpt-5.6-sol",
"prompt": "Review the complete PR diff for logical correctness."
}
]
}The second run on this head found no defects. |
2 participants
EN:
GET /map/places can restrict rows by a stored country, a shop name, and one blockchain and asset pair before the limit.
GET /map/filters returns the shop tokens plus the distinct countries, blockchains, and assets already stored.
Country stays null on existing pins until a real value is written, and an omitted support list does not invent one.
Publishing this branch does not change the live map until that service runs this build.
DE:
GET /map/places kann Zeilen vor dem Limit nach gespeichertem Land, Shop-Namen und genau einem Blockchain-Asset-Paar einschränken.
GET /map/filters liefert die Shop-Tokens und die bereits gespeicherten Länder, Blockchains und Assets.
Das Land bleibt bei bestehenden Pins leer, bis ein echter Wert geschrieben wird, und eine weggelassene Support-Liste erfindet keine.
Dieser Branch ändert die laufende Karte nicht, solange der Dienst diesen Stand nicht ausführt.
Details
Query names stay
country,shopName,blockchain, andasset.countryis the DFX country symbol (ISO 3166-1 alpha-2), trimmed and uppercased.blockchainis a DFX payment-network name, exact case, including testnets.assetis the DFX asset name, not a chain-prefixed unique name:ZCHFanddEUROare stored as written.blockchainandassettogether match one support row.shopName=SPARmatches that stored brand.shopName=othersmatches any other non-null brand. The optionaloriginfilter is unchanged. Omitting every filter still returns the public list.countryandshopNameare optional on create and update, so a body that only sends origin, external id, name, coordinates, and category still validates. Omitted supports on an update leave the stored rows. Present supports replace them. A new insert writes supports only when the row is actually inserted. Opening an existing database adds the new columns without filling country, and sets shop name to SPAR only where origin issparand shop name is still null. Deleting a pin deletes its support rows.