Skip to content

01a0dc6b - Offer hardcoded payment-link map filters - #11

Merged
TaprootFreak merged 3 commits into
openCryptoPay:developfrom
TaprootFreakAI:feat/01a0dc6b-map-filter-catalog
Oct 8, 2026
Merged

TaprootFreak merged 3 commits into
openCryptoPay:developfrom
TaprootFreakAI:feat/01a0dc6b-map-filter-catalog

Conversation

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator

EN:
The map filter now offers blockchain and asset from a hardcoded payment-link catalog, and a missing shop name counts as Others.
DFX shops match every payment-link network and asset, while 21.gifts matches only Lightning and BTC.
Shops that have no stored payment pairs stay on the map for that offer instead of disappearing.
A shop that already lists payment pairs still matches only those pairs.

DE:
Der Kartenfilter bietet Blockchain und Asset aus einem fest eingetragenen Payment-Link-Katalog, und ein fehlender Shop-Name zählt als Others.
DFX-Shops passen auf jedes Payment-Link-Netz und Asset, 21.gifts nur auf Lightning und BTC.
Shops ohne gespeicherte Zahlungspaare bleiben für dieses Angebot auf der Karte, statt zu verschwinden.
Ein Shop mit gespeicherten Paaren passt weiterhin nur auf diese Paare.

Details

GET /map/filters keeps shopNames as SPAR and others. Countries stay the distinct stored codes. Blockchains and assets are the hardcoded payment-link catalog plus any distinct stored values. ?blockchain= still narrows only the top-level asset list. The new techProviders field lists the full DFX.swiss offer and the 21.gifts offer (Lightning and BTC) and is not narrowed by that query.

The catalog is the payment-link networks without test networks and without Plasma, including BinancePay, KucoinPay, and Zano. Assets are the sellable names on those networks, including ckBTC, USDC.e, and USDbC. A chain and an asset together match only a real pair, so Ethereum plus BTC matches nobody until a shop stores that pair. Zano is listed and has no asset.

A pin with support rows is unchanged: the requested blockchain and asset must be the same stored row. A pin with no support rows uses the catalog. Origin 21gifts or tech provider 21.gifts matches Lightning and BTC only. Every other pin matches a catalog network, a catalog asset, or a catalog pair.

others now includes a pin whose shop name is missing, so the 21.gifts shops are Others rather than neither. SPAR is unchanged. BinancePay and KucoinPay are valid filter queries and are still rejected on a stored support body.

Polygon plus ZCHF is not a payment-link catalog pair, so a pin without support rows stays out of that filter.
The dead support predicate is ignored through the function close, and the handbook states the same blockchain and asset rules as the query validator.
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 2 review passes.
The place API offers hardcoded payment-link filters for shop name, blockchain, and asset, including pins that have no stored support rows.

DE:
Bereit nach 2 Review-Durchläufen.
Die Place-API bietet feste Payment-Link-Filter für Name, Blockchain und Asset, auch für Pins ohne gespeicherte Support-Zeilen.

Details

Head: 406ad7ad83eb38c11af60297d66cdeb83700d2e9
Runs: conformity-a with logic-a. The second run may be omitted.
Lane conformity-a:
Provider: grok.com
Model: grok-4.6
Model number: 1.0.34 (3736acbc8658)
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-a:
Provider: grok.com
Model: grok-4.6
Model number: 1.0.34 (3736acbc8658)
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 2, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "406ad7ad83eb38c11af60297d66cdeb83700d2e9",
  "passes": 2,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {"id": "conformity-a", "result": "pass", "status": "complete", "provider": "grok.com", "model": "grok-4.6", "model_number": "1.0.34 (3736acbc8658)", "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."},
    {"id": "logic-a", "result": "pass", "status": "complete", "provider": "grok.com", "model": "grok-4.6", "model_number": "1.0.34 (3736acbc8658)", "prompt": "Review the complete PR diff for logical correctness."}
  ]
}

Pass 1 found two handbook error sentences that did not match the query validator. Pass 2 reviewed the corrected sentences and the unreachable support-branch ignore and found no defects. The typecheck, lint, handbook, coverage, build, and end-to-end check is green on this head. Mergeable was MERGEABLE at post time.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review October 8, 2026 16:07
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 2 review passes.
The place API offers hardcoded payment-link filters for shop name, blockchain, and asset, including pins that have no stored support rows.

DE:
Bereit nach 2 Review-Durchläufen.
Die Place-API bietet feste Payment-Link-Filter für Name, Blockchain und Asset, auch für Pins ohne gespeicherte Support-Zeilen.

Details

Head: 406ad7ad83eb38c11af60297d66cdeb83700d2e9
Runs: conformity-b with logic-b. The second run may be omitted.
Lane conformity-b:
Provider: openai
Model: gpt-5.6-sol
Model number: 0.160.0
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-b:
Provider: openai
Model: gpt-5.6-sol
Model number: 0.160.0
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 2, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "406ad7ad83eb38c11af60297d66cdeb83700d2e9",
  "passes": 2,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {"id": "conformity-b", "result": "pass", "status": "complete", "provider": "openai", "model": "gpt-5.6-sol", "model_number": "0.160.0", "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."},
    {"id": "logic-b", "result": "pass", "status": "complete", "provider": "openai", "model": "gpt-5.6-sol", "model_number": "0.160.0", "prompt": "Review the complete PR diff for logical correctness."}
  ]
}

Second run found no defects. The pull request is already ready for review. The typecheck, lint, handbook, coverage, build, and end-to-end check is green on this head.

@TaprootFreak
TaprootFreak merged commit 9975efe into openCryptoPay:develop Oct 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants