Date review thread wait age from comment creation time - #206
Open
trask wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adjusts inline review thread “wait age” and ordering to use the last comment’s createdAt (not edit time) so typo-fixes to old comments don’t make stale threads appear newly raised.
Changes:
- Update
group_review_threadsto sort and timestamp comments bycreatedAtonly. - Stop requesting
updatedAtfor review thread comment nodes in the GitHub GraphQL query. - Add/extend tests and documentation to codify the intended timestamp semantics.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/scripts/pull-request-dashboard/dashboard.py | Uses createdAt for ordering and timestamps in inline review threads. |
| .github/scripts/pull-request-dashboard/github_cli.py | Removes updatedAt from GraphQL selections for review thread comments. |
| .github/scripts/pull-request-dashboard/test_dashboard.py | Adds coverage ensuring edits don’t reset thread wait age. |
| .github/scripts/pull-request-dashboard/RATIONALE.md | Documents the difference between inline thread vs top-level feedback timestamp behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull request dashboard statusWaiting on reviewers · refreshed 2026-07-30 22:24 UTC Review the latest changes. Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date an inline review thread's wait age and list position from its last comment's
createdAtrather than its edit time, so a reviewer fixing a typo in their own comment no longer makes a weeks-old thread look freshly raised. Over the 441 pull request corpus, 208 of 355 live threads currently derive their age from an edit; the median edit lands 3 minutes after the comment so most ages are unchanged, but 3 threads were edited more than a day later and the worst understated its wait by 14 days.updatedAtis no longer requested for review thread comments.Top-level feedback items still date from the edit time, and the difference is now stated in
RATIONALE.md: a top-level item is closed by an explicit author reply that is only reused while it stays newer than the item's root, so editing the request has to invalidate the reply already given. An inline thread has no such reply ledger, so an edit has nothing to reset.Fixes #195