Acknowledge routing overrides with the label instead of a comment - #204
Closed
trask wants to merge 1 commit into
Closed
Acknowledge routing overrides with the label instead of a comment#204trask wants to merge 1 commit into
trask wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Removes the redundant “routed this pull request…” acknowledgement comment by moving the override acknowledgement marker into the dashboard status comment, while preserving behavior that prevents /dashboard route:reviewers from being replayed.
Changes:
- Add override acknowledgement + override-label markers to the rendered PR status comment.
- Adjust override facts/no-op logic to distinguish “own label in flight” vs. already-overridden states.
- Update/expand unit tests and bump the status comment revision to roll out the new marker behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/scripts/pull-request-dashboard/test_pr_status_comment.py | Adds tests ensuring the status comment carries/omits the new override markers correctly. |
| .github/scripts/pull-request-dashboard/test_dashboard_override.py | Updates tests to reflect removal of the routed acknowledgement comment and new ack/label-marker behavior. |
| .github/scripts/pull-request-dashboard/state.py | Bumps STATUS_COMMENT_REVISION to roll out updated status comment rendering. |
| .github/scripts/pull-request-dashboard/pr_status_comment.py | Injects override ack + label markers into the status comment body. |
| .github/scripts/pull-request-dashboard/dashboard_override.py | Introduces OVERRIDE_LABEL_MARKER, derives new ack fields, removes comment-posting acknowledgement, and refines noop logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+128
to
+133
| # A command counts as acknowledged once its label is observed, and the | ||
| # status comment carries the marker from then on so label removal cannot | ||
| # replay the command. | ||
| "dashboard_override_ack_id": ( | ||
| max(acknowledged_id, command_id) if label_applied else acknowledged_id | ||
| ), |
Comment on lines
255
to
276
| message = ( | ||
| "only the pull request author or a member of an approving team can " | ||
| "use `/dashboard route:reviewers`." | ||
| ) | ||
| elif kind == "routed": | ||
| if reply.get("route") == "copilot": | ||
| message = ( | ||
| "accepted the reviewer-routing override; the reviewer handoff " | ||
| "is waiting on Copilot." | ||
| ) | ||
| else: | ||
| message = "routed this pull request to reviewers." | ||
| elif kind == "already_routed": | ||
| where = ROUTE_ALREADY_ROUTED_PHRASE.get( | ||
| reply.get("route") or "", "not currently waiting on you" | ||
| ) | ||
| message = ( | ||
| f"this pull request is {where}, so `/dashboard route:reviewers` had " | ||
| "no effect. The command only applies while the pull request is " | ||
| "waiting on you." | ||
| ) | ||
| else: | ||
| subcommand = reply.get("subcommand") or "" | ||
| attempted = DASHBOARD_COMMAND_PREFIX + (f" {subcommand}" if subcommand else "") | ||
| message = ( | ||
| f"`{attempted}` is not a recognized dashboard command. The only " | ||
| "supported command is `/dashboard route:reviewers`, which the pull " | ||
| "request author can use to move a pull request from waiting on the " | ||
| "author to waiting on reviewers." | ||
| ) |
Comment on lines
+124
to
+127
| "dashboard_override_acknowledged_id": acknowledged_id, | ||
| "dashboard_override_label_observed": _observed_override_label( | ||
| raw.get("issue_comments") | ||
| ), |
Comment on lines
+131
to
+133
| "dashboard_override_ack_id": ( | ||
| max(acknowledged_id, command_id) if label_applied else acknowledged_id | ||
| ), |
Member
Author
|
Closing, going in a different direction with #205 |
Pull request dashboard statusClosed · refreshed 2026-07-30 21:26 UTC Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard posted
@user routed this pull request to reviewers.after applyingdashboard:route-overridden, but the label event already shows that on the timeline, so the comment is redundant noise.That comment was load-bearing: it carried the acknowledgement marker that retires a
/dashboard route:reviewerscommand, and without it the command would be replayed each time the label is automatically released. The marker now rides the dashboard status comment, which is already maintained on every pull request. The status comment also records the override label it reported, so a label applied by hand stays distinguishable from the label a command just produced and a command on an already-overridden pull request still gets the "already routed" reply.Existing acknowledgement comments still satisfy the marker scan, so overrides that are in flight today are not replayed.