Skip to content

Add jittered backoff to dashboard state branch CAS retries - #203

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:state-branch-cas-backoff
Jul 31, 2026
Merged

Add jittered backoff to dashboard state branch CAS retries#203
trask merged 1 commit into
open-telemetry:mainfrom
trask:state-branch-cas-backoff

Conversation

@trask

@trask trask commented Jul 30, 2026

Copy link
Copy Markdown
Member

Dashboard state pushes lost the compare-and-swap race on a burst of concurrent webhook-triggered refreshes for the same repository (run 30574634907), because the retry loop allowed only 3 attempts with no delay, so every racer retried in lockstep and the loser kept losing. Raise the attempt limit to 8 and wait an exponentially backed-off, fully jittered delay before each refetch so concurrent writers de-synchronize.

@trask
trask requested a review from Copilot July 30, 2026 19:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds jittered exponential backoff to the dashboard state branch CAS retry loop to reduce lockstep retries during concurrent webhook-triggered refresh bursts.

Changes:

  • Increased CAS retry limit from 3 to 8 attempts.
  • Introduced fully-jittered exponential backoff (capped) before refetching state on a rejected push.
  • Improved retry logging to include the wait duration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/scripts/pull-request-dashboard/state_branch.py
@trask
trask requested a review from Copilot July 30, 2026 19:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@trask
trask marked this pull request as ready for review July 30, 2026 20:10
@trask
trask requested a review from a team as a code owner July 30, 2026 20:10
@trask
trask requested a review from maryliag July 30, 2026 20:10
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 30, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-07-31 12:48 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@trask
trask merged commit fb7afa6 into open-telemetry:main Jul 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants