Skip to content

Always show the route-override label on the dashboard - #190

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:always-show-route-override-label
Jul 30, 2026
Merged

Always show the route-override label on the dashboard#190
trask merged 1 commit into
open-telemetry:mainfrom
trask:always-show-route-override-label

Conversation

@trask

@trask trask commented Jul 29, 2026

Copy link
Copy Markdown
Member

The dashboard only rendered labels matched by a repository's labels_to_display config, so dashboard:route-overridden was invisible on dashboards for repositories that do not configure any label patterns. Since that label is applied by the dashboard itself to explain why a pull request is sitting in Waiting on reviewers, it is now always rendered inline after the PR title regardless of configuration.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 29, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-07-30 13:07 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures routing override labels remain visible without repository label configuration.

Changes:

  • Always renders dashboard:route-overridden.
  • Adds regression coverage.
  • Updates dashboard documentation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pull-request-dashboard/README.md Documents override-label behavior.
.github/scripts/pull-request-dashboard/test_render.py Tests unconditional override-label rendering.
.github/scripts/pull-request-dashboard/render.py Adds the override label to display patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@trask
trask marked this pull request as ready for review July 29, 2026 20:07
@trask
trask requested a review from a team as a code owner July 29, 2026 20:07
@trask
trask requested a review from mx-psi July 29, 2026 20:07
@trask
trask merged commit 7e54a97 into open-telemetry:main Jul 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants