Skip to content

Use write access for dashboard approvals - #134

Closed
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:use-write-access-for-dashboard-approvals
Closed

Use write access for dashboard approvals#134
trask wants to merge 1 commit into
open-telemetry:mainfrom
trask:use-write-access-for-dashboard-approvals

Conversation

@trask

@trask trask commented Jul 21, 2026

Copy link
Copy Markdown
Member

Determine dashboard approvers from repository collaborators with write access or higher, matching GitHub's green approval checkmarks. Remove per-repository approver-team configuration and the organization Members permission, and update the dashboard legend and documentation accordingly.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Closed · refreshed 2026-07-30 21:09 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dashboard approval eligibility to use repository collaborators with write access or higher.

Changes:

  • Replaces approver-team lookup with collaborator permission lookup.
  • Removes team configuration and organization Members permission.
  • Updates tests, dashboard labels, and documentation.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pull-request-dashboard/README.md Documents write-access approval behavior.
.github/workflows/pull-request-dashboard.yml Removes approver-team workflow input.
.github/workflows/pull-request-dashboard-repo.yml Removes team input and Members permission.
.github/scripts/pull-request-dashboard/WEBHOOK_SETUP.md Updates GitHub App permission guidance.
.github/scripts/pull-request-dashboard/test_github_cli.py Tests collaborator-based reviewer loading.
.github/scripts/pull-request-dashboard/test_dashboard.py Updates tests for the removed CLI option.
.github/scripts/pull-request-dashboard/repositories.json Removes repository approver-team configuration.
.github/scripts/pull-request-dashboard/render.py Updates approval icon descriptions.
.github/scripts/pull-request-dashboard/github_cli.py Loads reviewers from write-level collaborators.
.github/scripts/pull-request-dashboard/dashboard.py Integrates collaborator-based approval eligibility.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@trask
trask marked this pull request as ready for review July 21, 2026 22:43
@trask
trask requested a review from a team as a code owner July 21, 2026 22:43
@trask
trask requested a review from mx-psi July 21, 2026 22:43

@mx-psi mx-psi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TC has write permissions on every repo, so their approval would be counted as someone with write access but the ruleset may not allow maintainers to merge the PR. It's a small edge case, but maybe it could be confusing?

Otherwise looks good to me, if you think that this is not worth worrying about feel free to merge :)

@trask
trask marked this pull request as draft July 29, 2026 04:44
@trask

trask commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

The TC has write permissions on every repo, so their approval would be counted as someone with write access but the ruleset may not allow maintainers to merge the PR. It's a small edge case, but maybe it could be confusing?

Good point. GitHub gives them green checkmarks, but maybe better not to have that (incorrect?) behavior and tie more to CODEOWNERS. Will reconsider this later.

@trask trask closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants