Skip to content

fix(airflow): select latest pipeline runs - #33153

Open
IceS2 wants to merge 2 commits into
2.0from
backport/2.0/pr-32304
Open

fix(airflow): select latest pipeline runs#33153
IceS2 wants to merge 2 commits into
2.0from
backport/2.0/pr-32304

Conversation

@IceS2

@IceS2 IceS2 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Backports #32304 to 2.0.

Pipeline-status ordering now uses COALESCE(date_column, start_date) so asset-triggered runs with no logical date are selected chronologically. Includes SQLite regression coverage for logical-date and execution-date schemas across asset-triggered, mixed, and scheduled DAG runs.

Verified with pytest ingestion/tests/unit/topology/pipeline/test_airflow.py -q (44 passed).

@IceS2
IceS2 requested a review from a team as a code owner September 10, 2026 15:00
@IceS2
IceS2 requested review from Khairajani and removed request for a team September 10, 2026 15:00
@github-actions github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 35e79ce54848034a831049f18e9c2ef6a505235c in Playwright run 34502720603, attempt 1.

✅ 110 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 47m 45s

⏱️ Max setup 3m 18s · max shard execution 11m 39s · max shard-job elapsed before upload 17m 1s · reporting 5s

🌐 209.50 requests/attempt · 1.79 app boots/UI scenario · 0.00% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 209.5 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 1.79 per UI scenario (216 boots / 121 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 46 0 0 0 0 0
✅ Shard ingestion-01 38 0 0 0 0 0
✅ Shard ingestion-02 26 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot

gitar-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Backport of pipeline-status ordering fix using COALESCE(date_column, start_date) to select latest runs for asset-triggered DAGs without logical dates. Includes SQLite regression coverage for logical-date and execution-date schemas. No issues found.

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant