Fixes 33120: Move column-grid checks to component tests - #33121
Draft
pmbrull wants to merge 1 commit into
Draft
Conversation
Replace 22 browser variants with real component integration tests. Retain three browser contracts and preserve the full migration audit. Refs #33120
Code Review ✅ ApprovedMigrates 22 of 25 column-bulk-operations Playwright cases to 19 component integration tests, retaining three browser contracts for authenticated page, editor input, and bulk-update job verification. All 33 new and existing integration tests pass with comprehensive coverage of rendering, filtering, selection, drawer fields, discard, retry handling, and server-index propagation. No issues found. OptionsDisplay: compact → Counting what did not apply, without listing it. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes #33120
The column-bulk-operations suite uses a real backend to test many local UI states. Replace 22 of its 25 Playwright cases with 19 real component integration cases, retaining three browser contracts for the authenticated page, editor input, and the actual bulk-update job. The retained job test now verifies both occurrences were updated in the server index.
Preserve the complete Playwright/merge-queue analysis and classification exports for follow-up:
Type of change
High-level design
Render the actual grid, rows, controls, filters, drawer, editor, router and hooks in the existing Jest/Testing Library environment. A small HTTP test adapter replaces network transport while preserving REST request construction and Axios interceptors. Unexpected endpoints fail the test even if application error handling catches the rejection. Controlled responses and timers exercise asynchronous races.
The replacement assertions require real page changes, correct nested-child identity, exact per-occurrence update bodies, loading state, discard and failure/retry behavior. The retained browser helper opens the feature route directly because the shared sidebar helper expects an older navigation structure.
This is the first migration family, not a deletion of all 211 candidates. Permission, general pagination and nested-entity matrices need page-specific replacements. No production implementation, dependency, workflow or merge-queue policy changes are included. An exploratory same-ID cell-refresh concern is documented for follow-up; it does not justify any removed case.
The retiring cases consumed 6.65 cumulative worker-minutes in the audited run. This is historical worker cost, not a measured reduction in queue wall-clock latency.
Tests
Use cases covered
Rendering/statistics, filtering and URL state, empty results, stale responses, selection/counting, drawer fields, discard, exact bulk requests, pending/error/retry handling, unchanged-submit rejection, STRUCT expansion and cursor navigation. Real editor input and server-index propagation remain in Playwright.
Unit tests
ColumnGrid.integration.test.tsxand the existingColumnGridTableRow,NextPrevious, andusePaging.integrationsuites.ColumnGrid69.51%, listing hook 62.67%, filter hook 83.01%,ColumnGridTableRow94%,ColumnGridRow100%. These describe this suite, not whole-application coverage. No production classes changed.Backend integration tests
No backend API changes. The retained browser test submits a real job and polls the real grid index for both updated occurrences. No new Java integration tests.
Ingestion integration tests
Not applicable — no ingestion changes.
Playwright (UI) tests
Three retained tests passed in the standard Chromium project, one worker, no retries (52.7 seconds) against the workspace Vite UI and the local backend. Authentication state was prepared separately; full CI provisioning/sharding was not rerun.
Manual testing performed
No additional manual click-through. Automated browser validation logged in locally, opened the column page, edited text containing spaces, submitted a bulk display-name update and verified two indexed occurrences. Fixtures were cleaned up by the spec. Reproduction commands and prerequisites are in the migration document.
UI screen recording / screenshots
Not applicable — tests and documentation only; no production UI behavior or visual change.
Checklist
Fixes <issue-number>: <short explanation>.Fixes #33120.