Skip to content

[WIP] Add extension for wal-g incremental backups - #408

Draft
debebantur wants to merge 1 commit into
open-gpdb:OPENGPDB_STABLEfrom
debebantur:incremental-backups
Draft

[WIP] Add extension for wal-g incremental backups#408
debebantur wants to merge 1 commit into
open-gpdb:OPENGPDB_STABLEfrom
debebantur:incremental-backups

Conversation

@debebantur

@debebantur debebantur commented Aug 11, 2026

Copy link
Copy Markdown

Here are some reminders before you submit the pull request

  • Add tests for the change
  • Document changes
  • Communicate in the mailing list if needed
  • Pass make installcheck
  • Review a PR in return to support the community

@Alena0704

Copy link
Copy Markdown
Contributor

Hi Stepan, thanks for working on this!
A few questions on the design before I look at the code.

  1. Why an extension rather than core?
  2. How is the record made crash-safe? VACUUM can't run inside a transaction block, so the compaction and the INSERT into possible_vacuum_list are two separate commits. If the server crashes in between, the segfile is already rewritten but the vacuum is not recorded and it will corrupt an incremental backup.
  3. Why a new table instead of pg_aoseg? Did you consider deriving info from existing catalog/stats instead of a new table - e.g. pg_stat_all_tables.last_vacuum, or the eof/modcount in pg_aoseg?

Also, I'm worried that the module that installs a utility hook probably shouldn't be installable by a non-superuser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants