Skip to content

Add Latvian IDEMIA ID card support - #24

Open
martenrebane wants to merge 4 commits into
mainfrom
NFC-186
Open

martenrebane wants to merge 4 commits into
mainfrom
NFC-186

Conversation

@martenrebane

Copy link
Copy Markdown
Contributor
  • NFC-186


Signed-off-by: Marten Rebane marten.rebane@nortal.com

@martenrebane
martenrebane requested a review from metsma November 2, 2026 15:52
Comment thread Sources/nfclib/CardActions/Idemia.swift Outdated
}

final class Idemia: CardCommandsInternal {
final class Idemia: IdemiaCard {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better name? IdemiaEstonia?

var decryptAlgorithm: Bytes { get }
}

extension IdemiaCard {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base class just Idemia?

* operations come from ``IdemiaCard``. Overrides personal-data and certificate reads, and uses
* different key references for authentication and signing.
*/
final class LatviaIdemia: IdemiaCard {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ItemiaLatvia?

import Foundation

public enum CardType: String, Sendable, CaseIterable {
case id1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case id1
case idemiaEstonia


public enum CardType: String, Sendable, CaseIterable {
case id1
case thales

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case thales
case thalesEstonia

Finnish cards are also thales

public enum CardType: String, Sendable, CaseIterable {
case id1
case thales
case latviaIdemia

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case latviaIdemia
case itemiaLatvia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants