Skip to content

Add ConfV6 class with validateSigningCert method#692

Open
fl-ido wants to merge 1 commit into
open-eid:masterfrom
fl-ido:ignore-signing-certificate
Open

Add ConfV6 class with validateSigningCert method#692
fl-ido wants to merge 1 commit into
open-eid:masterfrom
fl-ido:ignore-signing-certificate

Conversation

@fl-ido

@fl-ido fl-ido commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

validateSigningCert method allows to bypass certificate trust check during signature verification.

Fixes #678

Signed-off-by: Florian Dargère florian.dargere@idopte.com

validateSigningCert method allows to bypass certificate trust check
during signature verification.

Fixes open-eid#678

Signed-off-by: Florian Dargère <florian.dargere@idopte.com>
@metsma

metsma commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Can you explain the reason?

@fl-ido

fl-ido commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

It allows to avoid checking the trust status of the signing certificate during signature verification, thus allowing the user to verify the trust status by himself, possibly using another store than TSL. The aim is to be able to verify signatures which have been signed with a certificate trusted from another source than TSL. It is an answer to #678 and #556 as well. I think it has to be a configuration parameter, in order to be customizable. Thus, I guess it needs a new configuration class, for binary compatibility.

@metsma

metsma commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Maybe we should figure out how to make X509CertStore usable as public API?

@fl-ido

fl-ido commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

Do you mean by making the X509CertStore::verify function virtual so that custom implementations could override the method with their own verification process ?

@metsma

metsma commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Do you mean by making the X509CertStore::verify function virtual so that custom implementations could override the method with their own verification process ?

Something like that. I need think about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow disabling of certificate check during signature verification

2 participants