[fix] Two more dev:fetch bugs found in batch 6 - #675
Open
kmturley wants to merge 1 commit into
Open
Conversation
- unzip exits 1 for recoverable warnings (e.g. "appears to use backslashes as path separators", routine for Windows-built zips) even though extraction completed fully. execSync treated any non-zero exit as failure, discarding a complete extraction and silently falling back to unreliable release-body text matching — which incorrectly tagged a Windows-only VST3 zip as also containing an Audio Unit because the release notes mentioned "AU" in an unrelated sentence about a future macOS build. Now swallows the unzip call's exit code and lets the existing dirHasFiles() check be the real success signal, consistent with every other archive type in this function. - License fingerprint matching now collapses whitespace before matching. A LICENSE file hard-wrapped at ~80 columns split "obtaining a copy" across a line break, so the literal-space MIT regex silently failed to match a byte-for-byte standard MIT license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two more
dev:fetchfixes found while continuing the plugin-batching effort (follow-up to #665):kevin-jenkins/PlugNspectr's Windows zip triggered unzip's "appears to use backslashes as path separators" warning (routine for Windows-built zips) — a non-fatal warning, butexecSyncthrows on any non-zero exit, soextractArchivebailed via its outer catch and returnednulleven though the archive was fully extracted. This silently skipped real archive-content inspection in favor of unreliable release-body text matching, which incorrectly tagged the filecontains: [vst3, component]— the release notes mentioned "AU" only in a sentence about a future macOS build, not this Windows asset. Fixed by swallowing the unzip call's exit code and relying on the existingdirHasFiles()check as the true success signal, matching every other archive type already handled this way in the same function.n0emo/hyperclip's LICENSE is byte-for-byte standard MIT, but hard-wrapped at ~80 columns split "obtaining a copy" across a line break — the regex required a literal space, so it silently didn't match. Now collapses whitespace (including newlines) before matching.Test plan
npm run checkpassesdev:fetchagainstkevin-jenkins/PlugNspectr— now correctly reportscontains: [vst3]only, matching the actual zip contents (verified by mounting/extracting it manually)n0emo/hyperclip— license now correctly detected asmitOTODESK4193/GlitchNexus,EyalDelarea/Cycloscope,subhankardas15071992-cloud/protoplug,008takeshi/Drawwave-Vocoder— all unchanged