Ericjenn srpwg wg1#119
Open
ericjenn wants to merge 1196 commits into
Open
Conversation
Signed-off-by: mariemturki93 <turkimariem39@gmail.com>
Signed-off-by: mariemturki93 <turkimariem39@gmail.com>
…ing-groups into ericjenn-srpwg-wg1
Signed-off-by: mariemturki93 <turkimariem39@gmail.com>
…ing-groups into ericjenn-srpwg-wg1
…ing-groups into ericjenn-srpwg-wg1
Signed-off-by: mariemturki93 <turkimariem39@gmail.com>
Signed-off-by: emanino <40175301+emanino@users.noreply.github.com>
Signed-off-by: emanino <40175301+emanino@users.noreply.github.com>
Signed-off-by: emanino <40175301+emanino@users.noreply.github.com>
Signed-off-by: emanino <40175301+emanino@users.noreply.github.com>
Signed-off-by: emanino <40175301+emanino@users.noreply.github.com>
…dition and batchnorm
…ing-groups into ericjenn-srpwg-wg1
Added a reference link to Why3 documentation for better understanding. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Updated formal guidelines to reflect completed suggestions. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Clarified the term 'specifier' for better understanding. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Clarified the definition of 'coordinates' in the documentation and noted completion of the suggested changes. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Corrected a typo in the term 'representatio' to 'representation'. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Added Why3 code example for the 'positive' predicate in formal guidelines. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Added note about Why3 standard library list usage in guidelines. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Added a reference to the Why3 standard library documentation for better guidance. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Clarified the guidelines regarding Why3 code usage and definitions. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Clarified inclusion instruction for tensors library. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Added a note indicating completion of a task regarding predicates in Why3 library. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Defined the concept of mathematical construct as part of the guidelines. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Clarified the definition of 'concrete representation' in the context of tensors and suggested alternatives for clarity. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Moved the 'Importance of this level' information to the beginning of the document for better clarity. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Removed reference to Loïc's proposal and clarified the guidelines. Signed-off-by: JeanLoupFarges <86069696+JeanLoupFarges@users.noreply.github.com>
Complete the informal specification of the Conv operator for floating-point types. Changes include: - add the missing floating-point signature - complete the floating-point informal specification - document IEEE754 floating-point semantics - add floating-point error conditions - add floating-point input/output type consistency constraints - reference the common restrictions and attributes defined in the real-number specification - replace vague references with explicit cross-references to the real specification - add a floating-point usage example - improve consistency with the Div operator specification and the SONNX specification guidelines Signed-off-by: HamzaSeyfu <165190579+HamzaSeyfu@users.noreply.github.com>
Rewrite the Concat informal specification to improve compliance with the SONNX specification guidelines. This commit: - reorganizes the document following the standard specification structure; - rewrites the informal specification for clarity and readability; - explicitly describes Concat as a structural operator; - introduces the mathematical definition progressively; - clarifies the role of the concatenation axis and cumulative offsets; - improves the description of the output shape; - replaces the step-by-step derivation with a clearer illustrative example; - restructures the Inputs, Outputs and Attributes sections; - clarifies shape, rank and type consistency constraints; - improves the description of error conditions and numerical accuracy; - harmonizes the document with the style used by recent operator specifications such as Div and Conv; - improves overall consistency with the SONNX documentation guidelines. Signed-off-by: HamzaSeyfu <165190579+HamzaSeyfu@users.noreply.github.com>
Signed-off-by: HamzaSeyfu <165190579+HamzaSeyfu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update of the SONNX working group material (located under directory "safety-related-profile")