MorphoERC4626SwapConnectors: restore deployed rounding fix on main - #176
Draft
Kay-Zee wants to merge 1 commit into
Draft
MorphoERC4626SwapConnectors: restore deployed rounding fix on main#176Kay-Zee wants to merge 1 commit into
Kay-Zee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The mainnet deployment of
MorphoERC4626SwapConnectors(0x251032a66e9700ef) contains the ceiling-rounding fix from #164, which merged to thev0branch and never reachedmain. With #175 now merged tomain, deployingmain's connector to production would silently revert that fix.Verified by diffing the deployed contract code against both branches: for this file, deployed ==
v0==main+ this fix.ERC4626UtilsandMorphoERC4626SinkConnectorsare identical across deployed /v0/main, so this one cherry-pick restores full parity for the ERC4626 Morpho surface.Change
Cherry-pick of 0df7dca (#164) onto
main, conflict-free. After this PR,main== production + #175 exactly for the contracts #175 deploys.Testing
flow test cadence/tests/MorphoERC4626SwapConnectors_test.cdcpasses with the fix and #175's liquidity gate combined, under both flow-cli v2.15.3 (CI pin) and v2.17.4 — the fork test applies the branch code as an in-place update over the real deployed mainnet state, which is the production update path.Note for release management
mainandv0have diverged; production tracksv0. Worth a maintainer decision on whetherv0merges intomainor future work rebases — outside this PR's scope.