Upgrade to Onfleet SDK 0.12.0, modernize toolchain, and add CI#2
Merged
Conversation
- Bump com.onfleet:driver to 0.12.0 and migrate the example to the new API (selfAssignTasks, getTasks flow, AccountStatus.INVITED, nullable getters, new SDKErrorType cases, attestationAge/customRequirements on completion) - Modernize toolchain: Gradle 9.3.1, AGP 9.1.0, Kotlin 2.1.0, compileSdk 36, minSdk 26, Java 21, Compose compiler plugin, Firebase BOM - Drop MultiDex (minSdk now 26) and the manual Compose compiler version - Update settings.gradle with pluginManagement/dependencyResolutionManagement - Refresh CHANGELOG.md with 0.12.0 notes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Add GitHub Actions CI (.github/workflows/ci.yml) building assembleDebug on pull requests targeting master; direct pushes to master are not allowed, so there is no push trigger. JDK 21 to match the Java 21 toolchain - Add Dependabot config (.github/dependabot.yml) for gradle + github-actions - Commit the Gradle wrapper (gradlew, gradlew.bat, gradle-wrapper.jar) so CI and fresh clones can run ./gradlew; un-ignore in .gitignore - Commit a non-functional placeholder app/google-services.json so the project builds out of the box; real config stays local via google-services.json.local - Stop tracking onfleet.properties; add onfleet.properties.example template and ignore the local copy - Add mavenLocal() to settings.gradle for local testing of unreleased SDK builds (publishToMavenLocal) before they hit Maven Central - Refresh README with setup/build/CI instructions Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mavenLocal() was added for local testing of the unreleased 0.12.0 build. 0.12.0 is now published to Maven Central, so the example resolves it from there; the line is kept (commented) for future pre-release local testing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 20 files
Confidence score: 3/5
- In
app/src/main/java/com/onfleet/sdk/onfleetclientexample/OnfleetClientExampleApplication.kt, plantingTimber.DebugTree()without theBuildConfig.DEBUGguard can expose verbose logs in production, which increases the chance of leaking internal/runtime details after release — restore the debug guard or use a release-safe tree before merging. - In
README.md, the documented CI behavior (pushes to master) does not match the actual workflow trigger (PRs only), which can mislead contributors and hide unmet expectations around continuous validation — update the README or add a matchingpushtrigger before merge. - In
app/build.gradle.kts, keeping Compose tooling underimplementationcan unnecessarily increase release artifact size and ship debug-only dependencies to users — move it todebugImplementationto de-risk the release footprint.
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
rSavarisOnfleet
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.onfleet:driver0.11.1 → 0.12.0 and migrate the example to thenew API (
selfAssignTasks,getTasksflow,AccountStatus.INVITED, nullablegetters, new
SDKErrorTypecases,attestationAge/customRequirements).compileSdk 36, minSdk 26, Java 21, Compose compiler plugin, Firebase BOM
(drops MultiDex).
assembleDebugon every PR tomaster.non-functional placeholder
google-services.json, and anonfleet.properties.exampletemplate (realonfleet.propertiesuntracked).Notes
masteronly — direct pushes tomasterare not allowed (branch protection to be enabled after the first green run).
settings.gradlekeeps a commented-outmavenLocal()for future localtesting of unreleased SDK builds; 0.12.0 resolves from Maven Central.
./gradlew assembleDebugsucceeds against the published0.12.0 (Gradle 9.3.1 / AGP 9.1.0 / JDK 21).