Conversation
A standard OMP 18.6 registry (962 models) serializes to 16385 nodes and exceeded the get_available_models node budget, so discovery failed with rpc-response-limit and left the provider in error. - get_available_models node budget 16384 -> 131072, so a full 4096-model catalog fits with headroom (about 17 nodes per model today) - OMP_MAX_CATALOG_MODELS 256 -> 4096 (matches MAX_MODEL_CATALOG_ITEMS); selection previously dropped every provider past the first 256 models - scale the 257-model boundary tests to 4097 and the oversize fixture so it still exceeds the node budget - add a 1500-model regression test that fails on the old budget Co-authored-by: Zahid <masruri03@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A standard OMP 18.6 registry (962 models) serializes to 16385 nodes. That exceeded the
get_available_modelsnode budget (16384), so discovery failed withrpc-response-limitand left the provider in error. Separately, model selection kept only the first 256 models and silently dropped every provider after that.Change
get_available_modelsresponse node budget 16384 -> 131072. A full 4096-model catalog is about 70k nodes (about 17 per model), so a smaller bound would still fail near the cap.OMP_MAX_CATALOG_MODELS256 -> 4096, matching the existingMAX_MODEL_CATALOG_ITEMS.omp-rpc-protocol.test.tsso it still exceeds the node budget.Verification
npm run typecheckclean.bun x biome check .clean.bun x vitest run: 849 passed, 7 skipped, 0 failed.Credit: the original fix is from @masrurimz (Zahid). This PR adds the budget alignment and tests.
Co-authored-by: Zahid masruri03@gmail.com