fix(runtime): preserve empty property strings - #2164
Draft
ohdearquant wants to merge 1 commit into
Draft
Conversation
ohdearquant
marked this pull request as ready for review
August 24, 2026 18:17
ohdearquant
commented
Aug 24, 2026
ohdearquant
left a comment
ohdearquant
left a comment
Owner
Author
There was a problem hiding this comment.
Automated review. Posted by this repository's automated pull-request review pipeline; this is not a human read and does not gate the merge by itself.
Verdict on head 5745213: REQUEST-CHANGES, 1 blocking finding. Finding details are delivered to the review's recipients rather than posted here. Do not merge this head while blocking findings are outstanding; a pipeline comment on a newer head supersedes this one.
ohdearquant
marked this pull request as draft
August 24, 2026 21:53
ohdearquant
added a commit
that referenced
this pull request
Aug 25, 2026
…ent-mode empty-drop (#2193) Amendment 3 to ADR-045: in Agent mode, empty strings nested under a record's `properties` object are preserved; the empty-string drop continues to apply everywhere else. A key under `properties` exists only because a caller wrote it, so an empty string there is data — it distinguishes "set to empty" from "absent or deleted". Under the unamended rule, the echo of an update that sets a property to `""` omits the key entirely and a successful write reads as a deletion (#1995). The token-economy rationale is unaffected: nothing machine-generated is reintroduced. Scope stated explicitly: empty arrays and objects under `properties` stay dropped; callers distinguishing those cases read `format=json` or `presentation=verbose`. Extending the carve-out to container values is a separate decision. Companion code change: #2164.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
propertiesduring Agent presentationpropertiesVerification
cargo fmt --all -- --checkcargo clippy -p khive-runtime --all-targets -- -D warningscargo clippy -p khive-pack-kg --all-targets -- -D warningscargo test -p khive-pack-kgcargo test -p khive-runtime --libupdate_empty_string_property_survives_agent_echo_and_readbackFixes #1995