feat(storage): add complete embedding-space identity - #2017
Draft
ohdearquant wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack and governance gate
codex/adr-160-phase-5-ranked-prefix).mainin135c3d46(docs(adr): mark ADR-160 accepted #2005). Keep this PR draft until the lower stacked phases and the Phase 4 operational rollout gates are satisfied and Claude completes review.What changed
EmbeddingSpaceIdentity/EmbeddingSpaceKeycontract inkhive-storage, derived from a complete protocol fingerprint plus dimensions rather than a display/model name.NamedVectorIdentityseam withvectors_for_embedding_space, binding the complete key to immutable SQLite vector-table geometry and rejecting conflicting first registration.Resource and failure-safety properties
1..=8192; derived table keys are restricted to 128 bytes.Regression guards
Validation
RUSTC_WRAPPER= cargo check --workspace -j4RUSTC_WRAPPER= cargo clippy --workspace --all-targets -j4 -- -D warningsRUSTC_WRAPPER= cargo test --workspace -j4python3 tests/test_moodboard_descriptor_golden.pycargo fmt --all -- --checkdeno fmt --checkon all eight modified Markdown filesbash -n scripts/ci.shgit diff --checkIndependent identity-contract, callsite/docs, registry-boundary, and resource reviews found no implementation Blocker/High/Medium issue.
Explicitly deferred to Phase 7
This PR does not migrate the text-provider registry, ANN/cache identities, or embedding-model schema. Accepted ADR-160 now fixes the configured lineage-slot and legacy-row mapping; Phase 7 implements that cutover and must also source a complete attested resolved-artifact identity covering provider/version, query/document transforms, pooling/execution semantics, and checkpoint digests. Those concerns remain outside this Phase 6 boundary.