Skip to content

feat(kg-editor): add bounded boundary evidence workbench - #1979

Open
ohdearquant wants to merge 3 commits into
rework/kg-editor-investigation-brieffrom
codex/kg-editor-boundary-workbench-1978
Open

feat(kg-editor): add bounded boundary evidence workbench#1979
ohdearquant wants to merge 3 commits into
rework/kg-editor-investigation-brieffrom
codex/kg-editor-boundary-workbench-1978

Conversation

@ohdearquant

@ohdearquant ohdearquant commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • turn a focused hidden-coupling pair into a bounded Boundary evidence workbench without adding a new URL or wire field
  • compare topology, SCC membership, hotspot/history/ownership evidence, shared commits, common neighbors, and direct dependency with honest tri-state coverage and fixed local bounds
  • reuse the pure comparison result in the investigation brief so UI and exported Markdown share availability, reason, window, and verification semantics
  • preserve pair context when inspecting either endpoint; retain a valid focused endpoint hypothesis when its producer row is absent

Evidence contract

  • source-revision mismatches and missing complete-page references fail closed
  • complete shared-commit evidence must equal the producer co-change count and stay inside its declared window
  • common-neighbor computation is indexed by neighbor and materializes only the six-row sample while retaining the exact declared tuple count
  • hotspot and ownership windows remain separately labelled
  • candidate evidence is never rendered as a defect, consolidation, duplicate, runtime, or source-role claim
  • dynamic Markdown status, reasons, paths, and verification prompts are code-span escaped

Stack

Validation

  • strict RED then GREEN for the pure model, component, integration, coverage, performance, and Markdown regressions
  • focused Vitest: 50 passed
  • full Vitest: 253 passed
  • typecheck, full lint, design-token contract, diff check, and webpack production build passed
  • standalone production Chromium: endpoint focus/pair preservation, labelled status, separate windows, empty console, and 375 px zero-overflow checks passed
  • temporary exact composition with feat(kg-editor): consume repository analysis catalog #1960 head fd6ba0e: 291 Vitest and 12 Chromium tests passed; feat(kg-editor): consume repository analysis catalog #1960 was not modified
  • independent exact-diff review: approved with no remaining findings

@ohdearquant ohdearquant mentioned this pull request Aug 15, 2026
Closed
ohdearquant
ohdearquant commented Aug 15, 2026
View reviewed changes

@ohdearquant ohdearquant left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review. Posted by this repository's automated pull-request review pipeline; this is not a human read and does not gate the merge by itself.

Verdict on head 662143d: REQUEST-CHANGES, 3 blocking findings. Finding details are delivered to the review's recipients rather than posted here. Do not merge this head while blocking findings are outstanding; a pipeline comment on a newer head supersedes this one.

@ohdearquant
ohdearquant marked this pull request as ready for review August 16, 2026 20:13
@ohdearquant @claude
fix(kg-editor): stop dropping boundary evidence on truncated pages
ad26398 
Three review findings on the boundary evidence workbench:

- buildScc threw when an SCC referenced a module outside the captured
  module page, taking down the whole coupling comparison instead of
  reporting that one SCC as truncated/unknown. It now only fails
  closed when the module page is complete, matching the existing
  buildCommonNeighbors fail-closed pattern.
- pageEvidence ignored next_cursor, so a page mid-pagination but not
  yet flagged truncated in its disclosure could render as complete.
- combinedAttentionMetric collapsed any non-unavailable input straight
  to "complete", so a truncated attention analysis with zero captured
  rows rendered as "no attention signal" instead of disclosing the
  truncation.

Also fixes the command-palette Cmd/Ctrl+K shortcut effect running on
every render instead of only when open state changes.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ohdearquant
ohdearquant commented Aug 19, 2026
View reviewed changes

@ohdearquant ohdearquant left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review. Posted by this repository's automated pull-request review pipeline; this is not a human read and does not gate the merge.

Verdict on current head: APPROVE, zero blocking findings. This is a comment, not an approval — a human reviewer decides whether to approve and merge.

@ohdearquant
Merge branch 'codex/kg-editor-investigation-brief' into codex/kg-edit…
ae3c773 
…or-boundary-workbench-1978

# Conflicts:
#	apps/kg-editor/src/components/showcase/repo-showcase.tsx
#	apps/kg-editor/src/components/showcase/repository-command-palette.tsx
#	apps/kg-editor/src/lib/investigation-brief.ts
#	apps/kg-editor/src/lib/repository-brief.test.ts
#	apps/kg-editor/src/lib/repository-brief.ts
@ohdearquant
ohdearquant changed the base branch from codex/kg-editor-investigation-brief to rework/kg-editor-investigation-brief August 21, 2026 22:36
ohdearquant
ohdearquant commented Aug 24, 2026
View reviewed changes

@ohdearquant ohdearquant left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review. Posted by this repository's automated pull-request review pipeline; this is not a human read and does not gate the merge by itself.

Verdict on head ae3c773: REQUEST-CHANGES, 3 blocking findings. Finding details are delivered to the review's recipients rather than posted here. Do not merge this head while blocking findings are outstanding; a pipeline comment on a newer head supersedes this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ohdearquant