Skip to content

Fix always reading from index 0 in the replaypaths ArrayList #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mariokeks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix always reading from index 0 in the replaypaths ArrayList #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 30 additions & 13 deletions addons/sourcemod/scripting/include/offstyledb_shavit.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,20 +242,37 @@ public void Shavit_AddAdditionalReplayPathsHere(int client, int style, float tim

public void Shavit_OnReplaySaved(int client, int style, float time, int jumps, int strafes, float sync, int track, float oldtime, float perfs, float avgvel, float maxvel, int timestamp, bool isbestreplay, bool istoolong, ArrayList replaypaths, ArrayList frames, int preframes, int postframes, const char[] name)
{
char replayPath[PLATFORM_MAX_PATH];
if (replaypaths != null && replaypaths.Length > 0)
{
replaypaths.GetString(0, replayPath, sizeof(replayPath));
}

// A non-canonical save (isbestreplay=false) is ours only if the path lives in
// our temp dir - other plugins may register their own extra replay paths too.
bool isOurCopy = !isbestreplay && replayPath[0] != '\0' && IsTempReplayPath(replayPath);
if(istoolong)
{
return;
}

if (!isbestreplay && !isOurCopy)
{
return;
}
char replayPath[PLATFORM_MAX_PATH];
// A non-canonical save (isbestreplay=false) is ours only if the path lives in
// our temp dir - other plugins may register their own extra replay paths too.
bool isOurCopy = false;

if(isbestreplay)
{
replaypaths.GetString(0, replayPath, sizeof(replayPath));
}
else
{
for(int i = 0; i < replaypaths.Length; i++)
{
replaypaths.GetString(i, replayPath, sizeof(replayPath));
if(IsTempReplayPath(replayPath))
{
isOurCopy = true;
break;
}
}

if(!isOurCopy)
{
return;
}
}

Records_HandleReplaySaved(client, isbestreplay, replayPath, isOurCopy);
}
Expand Down