[FIX] hr_holidays: don't allow user to select impossible day for month#5192
Draft
LucasDaniOV wants to merge 1 commit into
Draft
[FIX] hr_holidays: don't allow user to select impossible day for month#5192LucasDaniOV wants to merge 1 commit into
LucasDaniOV wants to merge 1 commit into
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-luoud, it needs to be retargeted before it can be merged. |
LucasDaniOV
force-pushed
the
master-hr-onboarding-time-off-accrual-ux-luoud
branch
4 times, most recently
from
70eea4c to
ba665fe
Compare
arpi-odoo
requested changes
Jul 8, 2026
Steps to reproduce: Time Off >> Configuration >> Accrual plans >> New > Create milestone >> Set frequency This code fixes the problem where a user could potentially (in the UX) choose an invalid day for the specified month, like 31 of February. Now this is not possible anymore. The user is able to choose 29 of February which is not always valid but this will be handled by backend. Task: 6333684
LucasDaniOV
force-pushed
the
master-hr-onboarding-time-off-accrual-ux-luoud
branch
from
ba665fe to
f98c496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce: Time Off >> Configuration >> Accrual plans >> New > Create milestone >> Set frequency
This code fixes the problem where a user could potentially (in the UX) choose an invalid day for the specified month, like 31 of February. Now this is not possible anymore.
The user is able to choose 29 of February which is not always valid but this will be handled by backend.
Task: 6333684