This repository was archived by the owner on Oct 17, 2026. It is now read-only.
Repository navigation
chore: update to the latest Common Tools app standard - #13
Merged
Merged
Conversation
The standard gained trusted signing, grant resets, and a single check per push since this app adopted it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Common Tools app standard changed after this app adopted it, in oddurs/common-tools #23–#25:
dev-certnever trusted its certificate, so builds could use an identity macOS considers invalid.scripts/agent, again in the pre-push hook.Approach
node scripts/standard.js applyfrom common-tools main. Only managed files change:scripts/dev-certtrusts the identity for code signing and resets this app's privacy grants, if it has any.scripts/tasksigns only with a valid identity, falling back to ad-hoc.make-icon.swift's header is updated.scripts/agentrecords the commit it checked, and.githooks/pre-pushskips repeating that check.standard.js checkpasses against this branch.Look at sceptically
dev-certhasn't been run yet. It changes the login keychain and asks for the password. Builds keep signing ad-hoc until someone runs it.