This repository was archived by the owner on Oct 17, 2026. It is now read-only.
Repository navigation
Conversation
Results could only be opened or revealed. Finder and Spotlight let you preview a file, copy its path, or quit the app you found, and a launcher that can't is a step backwards. The menu is a native NSMenu on ⌘K or a right-click, and Quick Look is the system panel.
oddurs
force-pushed
the
feat/action-menu
branch
from
October 17, 2026 03:01
c4e8be2 to
ae873dd
Compare
A live test showed the system Quick Look panel couldn't get the keyboard: the launcher never activates the app, so the preview opened while the previous app kept focus, the launcher closed itself, and later keystrokes went to that app. QLPreviewView in a non-activating panel that can't become key keeps the keyboard in the search field, so arrows move the selection with the preview following and no app activation changes at all.
Owner
Author
|
This repository moved into oddurs/common-tools as apps/command; open changes there. |
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A result could be opened, or revealed with ⌘↩, and nothing else. Finder and Spotlight let you preview a file, copy its path, or quit the app you just found.
Approach
ItemCommand.commands(for:isRunning:)(CommandKit, tested) decides what each result offers: files and apps get Open, Show in Finder, Quick Look, Copy Path, plus Hide and Quit when the app is running; links and panes get Open and Copy; a calculation only Copy.NSMenuunder the field for the selected result; a right-click shows the same commands through SwiftUI'scontextMenu(also anNSMenu). Menu items carry their symbols and the panel's own keys.QLPreviewViewin a non-activating panel that can never become key. The keyboard stays in the search field, so ↑ ↓ move the selection and the preview follows, ⎋ closes the preview first, and the app you were in stays active throughout.Look at sceptically
QLPreviewPanelneeds the app active to take the keyboard; the launcher never activates, so the preview opened while the previous app kept focus, the launcher closed itself, and keystrokes went to the other app. Replaced by the in-panel preview above (second commit). The replacement has not been seen on screen yet.QLPreviewViewrenders through Quick Look's service, so it can't be checked offscreen.Checklist
scripts/task checkpasses locally