fix: synchronize role parameters and clear obsolete restore source (release/1.4.0) - #1370
Open
wangyunlai-seekdb wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1369 to release/1.4.0.
Role transitions currently persist server_role_info without refreshing its in-memory parameter value, and promotion leaves the former upstream in log_restore_source. After ACTIVATE STANDBY, ROLE can therefore show PRIMARY while SHOW PARAMETERS still shows a standby role and an obsolete source.
Use the existing ObConfigManager save_config() and got_version() operations to persist each parameter and refresh the in-memory configuration. On planned or failover promotion, save PRIMARY first, then clear log_restore_source before enabling primary writes. If source cleanup fails after PRIMARY is durable, the command returns an error and the obsolete source remains harmless because primary runtime does not start standby log synchronization. Ordinary primary startup and repeated promotion preserve a newly preconfigured source for a future demotion.
The release branch does not contain the basic/crash-reentry obtest suite, so only production changes are backported. Regression assertions are included in master PR #1369.
Validation: