win-capture: Initialize window capture immediately - #13858
Open
prgmitchell wants to merge 1 commit into
Open
Conversation
Initialize new window capture instances with force_reset so the first lookup is not delayed by 1 second and instead happens on the next video tick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initialize new window capture instances with force_reset so the first lookup is not delayed by 1 second and instead happens on the next video tick.
NOTE: I did consider that using the OBS_SOURCE_DO_NOT_DUPLICATE flag for window capture sources would also fix but I am not sure if there is a specific reason we allow duplication for window capture sources but not display capture.
Motivation and Context
Fixes #4878
How Has This Been Tested?
Created two scenes with the same window capture source, enabled studio mode and the duplicate sources option, and then pressed the transition button to switch between the scenes. On the current release the program scene goes black for 1 second after pressing transition, with these changes it does not.
Types of changes
Checklist: