frontend: Refactor Idian widgets - #13765
Open
Warchamp7 wants to merge 4 commits into
Open
Conversation
Warchamp7
added
the
area/ui-ux
7 tasks
PatTheMav
requested changes
Aug 11, 2026
Warchamp7
force-pushed
the
idian-refactor
branch
3 times, most recently
from
August 12, 2026 20:07
3374529 to
0734aa1
Compare
Warchamp7
force-pushed
the
idian-refactor
branch
from
September 3, 2026 16:38
0734aa1 to
20a6b01
Compare
The idian widgets were built when we had a much lower understanding of how Qt expects you to build custom complex widgets and without a direct use-case. They were also built far too rigid for what every attempted use of them thus far has necessitated. These changes break them into simpler 'pieces' and provide getters for internals that are intended to be accessed.
Warchamp7
force-pushed
the
idian-refactor
branch
from
September 3, 2026 17:30
20a6b01 to
f73364f
Compare
github-project-automation
Bot
moved this from Ready For Review
to Requires Changes
in 33.0 Release Tracker
PatTheMav
reviewed
Sep 7, 2026
| namespace idian { | ||
| ExpandButton::ExpandButton(QWidget *parent) : InlineButton(parent) | ||
| { | ||
| widgetUtils = new Utils(this); |
Member
There was a problem hiding this comment.
What's the reason not to use smart pointers here? It doesn't seem that Utils needs to use Qt's parent-owner ownership model (which has been outdated for over a decade) and we should not perpetuate it in unrelated code.
The only place parent-owner ownership is permitted is for widgets and Qt objects, anything else needs to use smart pointers with clear lifetime and ownership rules.
Member
Author
There was a problem hiding this comment.
No good catch. Originally I wrote the Utils class as a QObject, but then had to convert it to a normal class to be able to use it for multiple inheritance (Qt only allows a class to inherit from a single QObject with multi inheritance).
These new Utils calls technically all leak that object since they're no longer cleaned up by Qt. I will convert them to smart pointers.
RytoEX
requested changes
Sep 10, 2026
Comment on lines
+21
to
+22
| #include <QStyleOptionButton> | ||
| #include <QPainter> |
Member
There was a problem hiding this comment.
Suggested change
| #include <QStyleOptionButton> | |
| #include <QPainter> | |
| #include <QPainter> | |
| #include <QStyleOptionButton> |
| // Convenience function to add a widget to the rows layout. | ||
| void addWidget(QWidget *widget) { layout()->addWidget(widget); } | ||
|
|
||
| // Convenience function to add a widget to the rows layout and then set it as the buddy. |
Member
There was a problem hiding this comment.
Suggested change
| // Convenience function to add a widget to the rows layout and then set it as the buddy. | |
| // Convenience function to add a widget to the row's layout and then set it as the buddy. |
Comment on lines
+21
to
+22
| #include <Idian/RowList.hpp> | ||
| #include <Idian/RowInfo.hpp> |
Member
There was a problem hiding this comment.
Suggested change
| #include <Idian/RowList.hpp> | |
| #include <Idian/RowInfo.hpp> | |
| #include <Idian/RowInfo.hpp> | |
| #include <Idian/RowList.hpp> |
github-project-automation
Bot
moved this from Ready For Review
to Requires Changes
in 33.0 Release Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the Idian widgets based after some slight usage in other PRs.
This has been extracted out from #13433
Motivation and Context
The idian widgets were built when we had a much lower understanding of how Qt expects you to build custom complex widgets and without a direct use-case.
They were also built far too rigid for what every attempted use of them thus far has necessitated. These changes break them into simpler 'pieces' and provide getters for internals that are intended to be accessed.
How Has This Been Tested?
Included in #13433
Types of changes
Checklist: