traces/rbac: use gogo/protobuf to match Tempo marshalling lib - #935
Closed
andreasgerstmayr wants to merge 1 commit into
Closed
andreasgerstmayr wants to merge 1 commit into
andreasgerstmayr wants to merge 1 commit into
Conversation
The response RBAC modifier unmarshals a Tempo API response, filters it,
and re-marshals it. To stay compliant with Tempo's API, that round-trip
must produce output identical to what Tempo sends, which means it has to
(un)marshal with the same library Tempo uses: gogo/protobuf.
This code used golang/protobuf's jsonpb instead, which disagrees with
gogo on empty repeated fields (gogo emits "[]", golang/protobuf omits
them). A zero-result /api/search therefore came back without the "traces"
field instead of Tempo's {"traces":[],...}.
Switch to gogo's jsonpb/proto so the modifier's output matches Tempo
marshalling and "traces" field is always present.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreasgerstmayr
force-pushed
the
fix/traces-rbac-use-gogo-jsonpb
branch
from
September 23, 2026 09:36
643cae9 to
57a5f83
Compare
Contributor
Author
|
Oh, this is basically the same as #934 (I worked on it yesterday but forgot to push). Main difference is that it uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The response RBAC modifier unmarshals a Tempo API response, filters it, and re-marshals it. To stay compliant with Tempo's API, that round-trip must produce output identical to what Tempo sends, which means it has to (un)marshal with the same library Tempo uses: gogo/protobuf.
This code used golang/protobuf's jsonpb instead, which disagrees with gogo on empty repeated fields (gogo emits "[]", golang/protobuf omits them). A zero-result /api/search therefore came back without the "traces" field instead of Tempo's {"traces":[],...}.
Switch to gogo's jsonpb/proto so the modifier's output matches Tempo marshalling and "traces" field is always present.