Skip to content

remove additional function execution #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
douglaskariuki022 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove additional function execution #2448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32cd639
remove additional function execution
douglaskariuki022 Jul 31, 2026
e63c093
switch function being called for consistency
douglaskariuki022 Aug 3, 2026
27fa20d
add unit test
douglaskariuki022 Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ export function maybeNiceInterval(interval, type) {
}

export function isTimeInterval(t) {
return isInterval(t) && typeof t?.floor === "function" && t.floor() instanceof Date;
return isInterval(t) && typeof t?.floor === "function";
}

export function isInterval(t) {
Expand Down
8 changes: 7 additions & 1 deletion test/options-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {assert, it} from "vitest";
import {identity, isNumericString, valueof} from "../src/options.js";
import {identity, isNumericString, valueof, isTimeInterval} from "../src/options.js";
import {isYearInteger, isYearIntegers} from "../src/options.js";

it("isYearInteger returns true for integers in [1500, 2500]", () => {
Expand Down Expand Up @@ -74,6 +74,12 @@ it("isNumericString only checks the first present value", () => {
assert.strictEqual(isNumericString(["notstring", "42"]), false);
});

it("isTimeInterval returns true for interval-like objects with a date floor", () => {
assert.strictEqual(isTimeInterval({range: () => [new Date()], floor: () => new Date()}), true);
assert.strictEqual(isTimeInterval({range: () => [0], floor: () => 0}), false);
assert.strictEqual(isTimeInterval({range: () => [0]}), false);
});

it("valueof returns nullish value", () => {
assert.strictEqual(valueof([], null), null);
assert.strictEqual(valueof([], undefined), undefined);
Expand Down