Skip to content

docs(layout): page-header 的 Responsive Behavior 按 PageHeader 现状改写 Spacing 一行 (#3902) - #3915

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-3902-pageheader-responsive-claim
Aug 9, 2026
Merged

docs(layout): page-header 的 Responsive Behavior 按 PageHeader 现状改写 Spacing 一行 (#3902)#3915
yinlianghui merged 1 commit into
mainfrom
claude/issue-3902-pageheader-responsive-claim

Conversation

@yinlianghui

Copy link
Copy Markdown
Collaborator

Fixes #3902

问题

content/docs/layout/page-header.mdx:229(Responsive Behavior 小节)写着
Spacing: Adjusts padding for different screen sizes」—— 这是 #3786 修掉的那个假断言
(pb-4 on mobile / pb-8 on desktop)的第四份副本。PR #3905 把 Styling → Container
收敛成「pb-4 at every breakpoint — there is no responsive variant」之后,这一页变成
自相矛盾:Container 说没有断点变体,四行之后的 Responsive Behavior 说 padding 会随
屏幕尺寸调整。读者信哪一条,取决于他翻到哪一节。

事实核对

基线 origin/main @ c2ecbaed9(已含 PR #3905 的合并点 50fa3766e),逐词对照
packages/layout/src/PageHeader.tsx:

改写后的措辞 代码依据
Identical at every breakpoint / there is no responsive padding variant :210 根 class flex flex-col gap-3 pb-4 border-b —— pb-4gap-3 都没有断点前缀;:211gap-x-4 gap-y-2:235gap-2 同样没有
the only breakpoint-driven change is the title's font size :231md:text-3xl整个文件里唯一带断点前缀的类(grep -cE '\b(sm|md|lg|xl|2xl):' = 1)
(see Styling → Title) 该节 :142 已写明 text-2xl on mobile / text-3xl on desktop

同小节另两行已核为真,未改动:Actions 换行由标题行的 flex flex-wrap(:211)兑现,
右对齐由右槽的 ml-auto(:235)兑现。

改法

只改 :229 这一行(1 行增 / 1 行删,单文件):

同页其余部分(含 #3786 / PR #3905 已收敛的 Styling 三节、以及 #3906 在议的定位问题)一律未碰。

验证

  • node scripts/check-doc-links.mjsLinks are valid across 7 scan roots.
  • node scripts/check-control-bytes.mjsOK (scanned 3792 tracked text file(s); skipped 85 binary);
    另按字节纪律自查 grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f]' 于改动文件零命中。
  • node scripts/check-changeset-presence.mjs → 「No source of a released package changed in
    this range, so no changeset is owed.」(纯 docs,未动任何发版包的 src/),故本 PR 不带 changeset。
  • 末次编辑后全仓 pnpm exec turbo run type-check --concurrency=2Tasks: 78 successful, 78 total(md-only 保险)。

反向验证:本改动是散文断言的改写,不含任何可执行分支,没有「把删掉的肢体装回去看诊断变红」
的可测等价物 —— 按注释-only 惯例豁免,如实记录。替代证据是上面那张改写句与代码逐词对照表
(每个短语都能指回一处 file:line)加门禁前后皆绿。

越界发现(未在本 PR 修)


Generated by Claude Code

…cing 一行 (#3902)

`content/docs/layout/page-header.mdx:229` 的「Spacing: Adjusts padding for
different screen sizes」是 #3786 修掉的那个假断言的第四份副本:
`packages/layout/src/PageHeader.tsx:210` 的根 class 是
`flex flex-col gap-3 pb-4 border-b`,padding 与 gap 都没有断点变体;整个文件
里唯一带断点前缀的类是标题的 `md:text-3xl`(:231)。PR3905 落地后,Styling →
Container 说「at every breakpoint — there is no responsive variant」,四行之后
的 Responsive Behavior 却说 padding 随屏幕尺寸调整 —— 同一页自相矛盾。

按现实改写这一行,并沿用 #3786 在 Container 节定下的措辞;真正随断点变化的
标题字号只做指向(Styling → Title 已有该数值),不再复制具体数值,避免这个
断言长出第五份副本。同小节 Mobile / Desktop 两行已核为真(标题行
`flex flex-wrap` :211、右槽 `ml-auto` :235),不动。
@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Aug 9, 2026 2:01am

Request Review

@yinlianghui
yinlianghui marked this pull request as ready for review August 9, 2026 02:35
@yinlianghui
yinlianghui added this pull request to the merge queue Aug 9, 2026
Merged via the queue into main with commit 09987b6 Aug 9, 2026
18 checks passed
@yinlianghui
yinlianghui deleted the claude/issue-3902-pageheader-responsive-claim branch August 9, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants