Skip to content

feat(plugin-detail): record:related_list reads showViewAll, and "View all" opens the parent-scoped list (objectui#12741) - #12796

Merged
objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-12741-related-list-view-all
Oct 16, 2026
Merged

objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-12741-related-list-view-all

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12741
Clause-②: yes

record:related_list reads showViewAll, and its "View all" link opens the related object's records filtered to this parent. This is ENFORCE, the objectui half of objectstack-ai/objectstack#23941. The verdict carries over from the maintainer's ruling 5902374623 on objectstack-ai/objectstack#20665, with #11263 as the precedent.

Clause-② is yes because @object-ui/react's exported RelatedRecordHandlers gains one optional member, onViewAll. No input, spec key or accept set changes. The claim anticipated this flip.

What changed

  • @object-ui/react: RelatedRecordHandlers.onViewAll?: () => void. The host returns it from resolve to open the child object's list page, scoped to the parent on the relationship it was handed. As with every handler on this interface, omitting it hides the affordance.
  • @object-ui/app-shell: RelatedRecordActionsBridge resolves onViewAll to the ADR-0055 bare data surface, /apps/APP/OBJECT/data?filter[REL]=PARENT. recordListPath is extracted from useOpenRecordList, so the dashboard drill and View all spell this route in one place. The link is withheld where the route cannot show "this parent's children":
    • when the list has no relationship or no parent value;
    • for a multiple: true relationship, because the URL grammar has no membership operator (the reason RelatedList's raw-URL fetch refuses it);
    • for a relationship field the viewer cannot read, because ObjectDataPage drops that condition and would open the whole table.
  • @object-ui/plugin-detail:
    • The renderer passes onViewAll unless showViewAll === false. When the key is absent, the spec default true applies.
    • RelatedList draws the link whenever it has onViewAll and records. The old gate drew it only when records ran past one page, and the spec states no such condition. This renderer is the only caller that passes onViewAll.

Measured before building (the card's premise)

  • H1 confirmed: at main 236624d, the renderer read neither showViewAll nor onViewAll.
  • H2 confirmed: the route exists. AppContent.tsx registers :objectName/data for ObjectDataPage, which parses filter[FIELD]=VALUE and shows each condition as a chip. useOpenRecordList already navigates there. No page or URL spelling was invented.
  • H3: the truncation-only gate was dropped (above).
  • H4: no booking. The parity file's MEMBER_PINS holds member shapes of array/object inputs only, and a test asserts every pin names one. A boolean has no slot, and the file passes unchanged.
  • H5, measured live: the seeded admin's sys_user record page, Positions tab. The platform page authors showViewAll: true with limit: 25 and 4 rows.

Live reading

Setup: a published @objectstack/*@18.0.0-next.2 backend (e2e/live/ci/start-backend.sh, showcase e5136ff10f1a) and the console dev server from each tree. PNGs are on branch claude/issue-12741-evidence under evidence/12741/:

  • before-sys-user-positions.png (base 236624d): no "View all" on any of the 10 tabs.
  • after-sys-user-positions.png: "View all" under the 4 rows.
  • after-view-all-target.png: the click lands on /apps/setup/sys_user_position/data?filter[user_id]=ADMIN_ID, which shows 4 records and the chip "User = ADMIN_ID".

Tests

  • packages/plugin-detail/src/__tests__/RecordRelatedListRenderer.showViewAll-12741.test.tsx: through the real SchemaRenderer, registration, RelatedList and data table.
    • Absent: the link draws with every row fitting, and calls the host.
    • true: the link draws.
    • false: no link (control: the header's New is drawn).
    • Empty list: no link.
    • A host with no destination, or no host: no link.
  • packages/app-shell/src/views/__tests__/RelatedRecordActionsBridge.viewAll-12741.test.tsx: through the real bridge under a router.
    • The click goes to /apps/demo/task/data, and the search reads back via parseUrlFilterTriples as exactly [project, =, P-1].
    • false, a multi-value relationship and an unreadable relationship field each draw no link.
    • Control: a denied field the relationship does not use keeps the link.
  • Ablations: each went red on the expected rows (2, 4, 4, 1, 1 and 1 failing tests), and the tree was restored to the HEAD blob each time.
    • ignoring false;
    • not passing onViewAll;
    • restoring the truncation gate;
    • dropping the multi-value guard;
    • dropping the FLS guard;
    • pointing at the object route.
  • Two existing bridge test doubles (createPredicates, effectiveOps) mocked usePermissions without the required checkField. They gain an open one.
  • Results:
    • Families at d040dd8: plugin-detail whole plus 141 grep hits, 420 passed and 1 failed. The failure was the doubles above, fixed in 85decad.
    • After merging main at f439fc1: 69 files and 1025 tests passed.

Gates

At f439fc1 the following exit 0:

  • check:changeset-claims, changeset:check, check:test-path-roots, check:spec-symbols, check:new-line-citations and check-changeset-presence;
  • type-check of react, plugin-detail, app-shell and console, after their closure builds;
  • eslint on the changed files: 0 errors, and no warning on an added line.

The i18n family is not owed: no t() call or rendered string changed.

Acceptance notes

Provenance: built by the cloud session session_01FRjGDuZzqZg3Dk3Wd2V1Ph (claim 6223401330) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. Before opening, the seat asked for one doc-only commit, 043c3b0: recordListPath moved above useOpenRecordList's docblock so each docblock sits on its own function (a pure move, 27/27 lines; app-shell type-check and 18 files / 101 tests green at that head). The seat replaced the dev's footer lines with this paragraph and changed nothing else.


Generated by Claude Code

…"View all" to the parent-scoped list

The contract declares `showViewAll: z.boolean().default(true)`, "Show
'View All' link to see all related records", and nothing read it: no host
passed `RelatedList` an `onViewAll`, so the declared default drew nothing.

- `@object-ui/react`: `RelatedRecordHandlers` gains an optional `onViewAll`.
- `@object-ui/app-shell`: the record-page bridge resolves it to the ADR-0055
  bare data surface, `/apps/APP/OBJECT/data?filter[FIELD]=PARENT`, through
  `recordListPath`, now shared with `useOpenRecordList`. It is withheld
  where that route cannot show this parent's children: no relationship or
  parent value, a `multiple: true` relationship, or a relationship field
  the viewer cannot read.
- `@object-ui/plugin-detail`: the renderer passes it unless
  `showViewAll === false`. `RelatedList` draws the link whenever it has
  `onViewAll` and records, without the old truncation-only gate the spec
  does not state.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FRjGDuZzqZg3Dk3Wd2V1Ph
`RelatedRecordActionsBridge` now reads `perms.checkField` for the related
list's "View all" (objectui#12741). Two bridge tests mocked
`usePermissions` with a partial object that omitted it, and
`PermissionContextValue` declares it required. The doubles gain an open
`checkField`.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FRjGDuZzqZg3Dk3Wd2V1Ph
…r own docblock

`recordListPath` was inserted between `useOpenRecordList`'s docblock and
its function, so hover docs attached to the wrong symbol. The block moves
above that docblock. No code change.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FRjGDuZzqZg3Dk3Wd2V1Ph
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 75 chunks) 3128.3 KB 3744.1 KB
Main entry chunk (gzip) 75.6 KB 350 KB
Entry file index-CRUG1PWD.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.42KB 7.85KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 41.15KB 10.86KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 602.20KB 145.57KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.96KB 69.45KB
fields (index.js) 291.36KB 74.46KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.67KB 11.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 146.23KB 39.59KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 263.65KB 69.71KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.28KB 46.60KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 270.84KB 75.07KB
plugin-kanban (index.js) 59.42KB 18.48KB
plugin-list (index.js) 132.61KB 34.08KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 94.68KB 24.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.23KB 39.46KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T21:19Z

What was reviewed:

  • Head 043c3b0, against objectui#12741.
  • The claim 6223401330, and the dev's report with the seat's answers on the card.
  • Tier: TIER_DEFAULT, the seat's own review. Clause-②: yes is on line 2 of the body and at the start of a line in all three changesets. It is widening only: one optional member, onViewAll, on @object-ui/react's exported RelatedRecordHandlers; no input, spec key or accept set narrows. So no contract-review tier is owed.
  1. Shape.
    • Fixes #12741 is the first line and the only closing keyword. The assignee is os-tesla.
    • 12 files, NOT governed (check-governed-merges --pr on this file list, 508 changed lines): the react context, the app-shell bridge and useOpenRecordList, the plugin-detail renderer and RelatedList, two new tests, two existing test doubles and one changeset each for @object-ui/react, @object-ui/app-shell and @object-ui/plugin-detail.
  2. The change.
    • record:related_list reads showViewAll: absent or true hands RelatedList the host's onViewAll; false draws no link. This is ENFORCE, the objectui half of spec(ui): record:related_list.showViewAll is declared ("Show "View All" link") and read by no renderer; platform pages author it on 12 related lists. Enforce or retire objectstack#23941.
    • The bridge resolves onViewAll to the existing ADR-0055 bare data surface (/apps/APP/OBJECT/data?filter[REL]=PARENT) through recordListPath, now the one spelling of that route that the dashboard drill also uses. It withholds the link where that route cannot show this parent's children: no relationship or parent value, a multiple: true relationship, or a relationship field the viewer cannot read.
    • RelatedList drops the truncation-only gate the spec does not state; this renderer is its only onViewAll caller.
    • 043c3b0 (asked for by the seat before the PR opened) moves recordListPath above useOpenRecordList's docblock, so each docblock sits on its own function. A pure move.
  3. Tests and evidence.
    • 11 new pins across the renderer (through the real SchemaRenderer and data table) and the bridge (under a router, reading the URL back through parseUrlFilterTriples). Six ablations, each red on the expected rows; each restored blob equals HEAD.
    • Families: 420 passed at d040dd8 with the one failure the two test doubles caused, fixed in 85decad; 69 files / 1025 tests after the main merge; 18 files / 101 tests at 043c3b0.
    • Live against a published 18.0.0-next.2 backend: the seeded admin's sys_user Positions tab drew no "View all" at base and draws it at the branch; the click lands on /apps/setup/sys_user_position/data?filter[user_id]=ADMIN_ID with 4 records and one chip. The PNGs are at c50137b on claude/issue-12741-evidence.
  4. Gates (check-runs pinned to this head).
    • 33 success and 3 skipped (coverage and dependabot, skipped by design), including Lint, Type Check, Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Repo Gates, Governed Surface Queue Guard and every changeset check.
  5. Recorded, not changed:
  6. Landing.
    • Ready, then auto-merge into the merge queue.
    • After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_01FRjGDuZzqZg3Dk3Wd2V1Ph.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants