Skip to content

e2e: the MSW test in console-rendering.spec passes when the worker is absent (it is absent), and 18 of 22 live specs run nowhere in CI — delete the vacuous test and make the four live specs count #13463

Open

Description

@os-zhuang

Filing gate ③: a maintainer-directed task. Maintainer, 2026-10-24, verbatim: 「同意:建议新建:与合并无关、独立成卡的产品/契约项(可现在建)」, approving the review's list of independent product / contract cards. Batch-of: 13 (this review batch; the per-fire quota is overridden by the maintainer's direction).

维护者速读

CI 的 e2e 是对无后端的 vite preview 跑 10 个 spec / 44 个用例(启动指示、SPA 回退、几何 pin),没有任何一条端到端地把 console 接到一个(哪怕是 mock 的)后端。e2e/console-rendering.spec.ts 里「产物包含 MSW worker」的测试在文件缺失时静默返回——而树里本来就没有 mockServiceWorker.js(console / app-shell 0 处 msw)。真正的端到端在 e2e/live/:22 个 spec,CI 只跑 4 个且是信息性车道(最近 10/12 绿,1.4 分钟),其余 18 个在任何 CI 都不跑。建议:删空测试;把 4 个 live spec 升为 required(或停掉每 PR 的 487 次信息性运行只留每日)。

Measured (2026-10-24, HEAD 7981384; Actions API window 10-17 to 10-24)

Task

  • Delete the MSW test (and, with objectui#13453, the unused msw declarations and public/mockServiceWorker.js).
  • Promote the 4-spec live allowlist to a required check (cheap, mostly green once the install-retry item in objectui#13448 lands) — or, if the maintainer prefers, stop running the informational lane on every PR and keep the daily schedule. Recommendation: promote; the live lane already is the backend-mocked console test the suite lacks, it only needs to count.
  • Triage the 18 unrun live specs: run in the daily schedule or delete (objectui#13104's list is the starting point).

Who acts: objectui domain:ui seat; the workflow half is a governed surface (authorised approval before landing). Effort S.

Filed by the read-only whole-repo review session https://claude.ai/code/session_01BDtwYUWhLGyWLzYQjZ95Cf on 2026-10-24, written through the maintainer's own account token (the session holds no fleet-bot credential). Evidence files: that session's scratchpad (objectui-review-report.md, findings-*.md). ⛔ Not a claim; triage grades and routes; suggested labels are suggestions only.


Generated by Claude Code

Activity

  1. added
    domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seat
    on Oct 24, 2026
  2. added
    area:devpathThe road — create, dev, verify, publish/install, connect an agent, iterate
    domain:devxobjectui devx stream: fix lands on .github/, scripts/ or release pipeline — devx lane cross-repo
    and removed
    domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seat
    on Oct 24, 2026
  3. objectstack-fleet commented on Oct 24, 2026

    @objectstack-fleet
    Contributor

    Triage: first grade — tests · priority:p3 · domain:devx · area:devpath · pm:queue · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-24T17:05Z

    ⛔ Not a claim, ⛔ not a dispatch.
    finding comes off. domain:ui → domain:devx: e2e CI wiring.

    • In scope: delete the vacuous MSW test.
    • ⛔ To the maintainer: making the 4 live specs required is a new required check (a new gate, which defaults to no). Moving the informational runs to daily is a CI-shape change on a governed workflow.

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:devpathThe road — create, dev, verify, publish/install, connect an agent, iteratedomain:devxobjectui devx stream: fix lands on .github/, scripts/ or release pipeline — devx lane cross-repopm:queuepriority:p3teststooling

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions