docs(adr-0056): the AdminScopeSchema target shape still lists the two delegated-admin keys the spec retired (manageBindings, authorEnvironmentSets) #12660

Activity

1. objectstack-fleet

   added

   finding

   on Oct 16, 2026
2. objectstack-fleet commented on Oct 16, 2026

   

   objectstack-fleetBot

   on Oct 16, 2026

   ContributorAuthor

   More actions

   Triage: first grade, documentation · priority:p3 · domain:ui · area:access · pm:queue · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-16T13:14Z

   Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015). ⛔ Not a claim, ⛔ not a dispatch.

   • Re-read on main 4be76e0306: docs/adr/0056-permission-editing-studio.md:142 still lists manageBindings and authorEnvironmentSets beside manageAssignments. The filed reading holds.
   • Why p3: it is ADR text. Studio's switches go with PR feat(app-shell): Studio retires the two delegated-admin switches the spec retired (objectui#12406) #12659, and the installed spec refuses both keys at every door, so an author following the ADR is refused loudly.
   • Why domain:ui: the filing seat holds the Studio half (objectui#12406). docs/adr/** is governed text here (Tier H), so the PR needs a GOVERNED_APPROVERS approval, as the card says.
3. objectstack-fleet

   added

   area:accessPermissions that actually hold — RLS/FLS, sharing model, write-path guardsPermissions that actually hold — RLS/FLS, sharing model, write-path guards

   documentationImprovements or additions to documentationImprovements or additions to documentation

   domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatobjectui ui stream: fix lands on the published library or apps — objectui execution seat

   pm:queue

   priority:p3

   pm:dispatched

   and removed

   pm:queue

   on Oct 16, 2026
4. objectstack-fleet

   assigned

   baozhoutao

   on Oct 17, 2026
5. objectstack-fleet commented on Oct 17, 2026

   

   objectstack-fleetBot

   on Oct 17, 2026

   Last edited by objectstack-fleet

   ContributorAuthor

   More actions

   Claim: PM loop round 3 (priority:p3 documentation, governed text: Tier H)
   Session: session_01XVp19E1MYUTFM3dnkwz8gB
   Account: baozhoutao (the seat's linked user as GET /user answers it; the card's assignee)
   Branch: claude/issue-12660-adr0056-admin-scope
   Worktree: objectui-issue-12660
   Domain: domain:ui
   Seat: domain:ui#2
   File surface: docs/adr/0056-permission-editing-studio.md, the AdminScopeSchema bullet (about :140–143): list the live keys only, and say manageBindings and authorEnvironmentSets were retired by objectstack-ai/objectstack#23488; and, amended in place after the contract review of PR #12903, the P3 implementation-log entry (about :212–215), which still lists the -bindings / author-env-sets toggles that objectui#12659 removed from the Studio editor. Same file, same family, one governed approval. No other line, file or changeset (docs only). Stop on breach; explain in the report.
   Container & model: S, mode:subagent, model: sonnet (floor tier: a one-bullet text amendment; dispatch-gates --tier --repo objectstack-ai/objectui reads no path-derived mandate). The path is governed (docs/adr/**, Tier H), so the PR owes a CONTRACT_REVIEW_TIER review of the rule text and waits visibly for a GOVERNED_APPROVERS approval; this seat never approves or merges it.
   Clause-②: no
   Responsibility: n/a — not a defect card (governed ADR text that names two keys the spec refuses)
   Thread-read: 6216298563
   Serial constraints cleared: no open objectui PR and no pm:dispatched claim names docs/adr/0056-permission-editing-studio.md (read at claim). This seat's in-flight objectui#12838 (packages/plugin-kanban, packages/i18n) and objectui#12736 (packages/types) are disjoint.
   Claimed at: 2026-10-17T15:24Z
6. objectstack-fleet commented on Oct 17, 2026

   

   objectstack-fleetBot

   on Oct 17, 2026

   ContributorAuthor

   More actions

   os-dev-report
   {
   "issue": 12660,
   "status": "done",
   "branch": "claude/issue-12660-adr0056-admin-scope",
   "pr": "#12903",
   "session": "session_01XVp19E1MYUTFM3dnkwz8gB",
   "premise_still_valid": true,
   "summary": "Amended only the AdminScopeSchema bullet in docs/adr/0056-permission-editing-studio.md: lists the 4 live keys (businessUnit, includeSubtree, manageAssignments, assignablePermissionSets[]) plus one clause that manageBindings and authorEnvironmentSets were retired by objectstack#23488. Draft PR opened with assignee baozhoutao, Clause-2: no, and the Chinese maintainer-readout section (seat opinion empty).",
   "tests": "Measured installed @objectstack/spec 18.0.0-next.3: shape keys = 6; safeParse with manageBindings or authorEnvironmentSets fails invalid_type expected never ('removed in @objectstack/spec 18'); bare businessUnit parses; no other drift. check-changeset-presence exit 0 (no changeset owed); pnpm check:doc-example-readers exit 0; pnpm check:new-line-citations exit 0; control-char scan clean; scripts/check-nul-bytes.mjs absent in objectui (MODULE_NOT_FOUND, not a verdict). No code, no package tests.",
   "mcp_calls": "0",
   "api_writes": "2 relay writes via fleet-write: PR create (with assignee leg) and this report comment; plus 1 git push of the branch and 1 content push",
   "open_questions": [],
   "out_of_scope_findings": []
   }

   ---

   Generated by Claude Code
7. objectstack-fleet commented on Oct 17, 2026

   

   objectstack-fleetBot

   on Oct 17, 2026

   ContributorAuthor

   More actions

   Review: ACCEPT (Tier H: waits for a maintainer approval) — objectui PR #12903 · domain:ui seat 2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-17T15:52Z

   Reviewed on GitHub at head 2e2c31b, against the card's Ask, the triage note (6216298563) and the claim (6235723431, amended in place to add the P3 log entry).

   • Shape: the body says Fixes #12660; the second line is Clause-②: no. Docs only: one file, no changeset owed (check-changeset-presence exits 0, and the changeset checks are green).
   • The change (docs/adr/0056-permission-editing-studio.md):
     • The target shape. The AdminScopeSchema bullet lists the four live keys (businessUnit, includeSubtree, manageAssignments, assignablePermissionSets[]). One clause says manageBindings and authorEnvironmentSets were retired by [finding] AdminScope.manageBindings and authorEnvironmentSets are honoured by no write path after C3; the ADR-0090 D9/D12 junction gates are unmeasured; permissions docs describe removed gates objectstack#23488 and that the spec refuses both. Measured on the installed @objectstack/spec 18.0.0-next.3: the schema keeps both keys only as retiredKey tombstones.
     • The P3 log entry (patch round 2e2c31b, found by the contract review). It no longer lists the -bindings / author-env-sets toggles as present. It says they were removed with objectui#12659, which the dev confirmed on main: the editor draws no control for either, and a pin asserts it.
   • Governed path. docs/adr/** is Tier H. This PR stays a draft, carries needs-user-decision, and waits for an approval from a GOVERNED_APPROVERS account; review is requested from both. This seat does not mark it ready, queue it or approve it until that approval is on record. The maintainer brief is posted on the PR.
   • Contract review: PASS at this head, CONTRACT_REVIEW_TIER, by an isolated reviewer and adopted by this seat (PR comment 6235918694; it supersedes the PASS on 13d8ebd). The two body wordings it flagged ("only that bullet", and the rollback line of the brief draft) are corrected in the PR body.
   • Trailers: both commits carry only the model-free pair.
   • CI at head: 29 success, 3 skipped, 0 failures (filter=latest, 32 runs). Governed (path audit: 1 of 1 path, docs/adr/**, Tier H); 12 changed lines.

   Next: the maintainer's approval; then this seat lands it (pr_ready + automerge_enable).

   ---

   Generated by Claude Code
8. os-zhuang

   closed this as completedin #12903on Oct 17, 2026
9. objectstack-fleet commented on Oct 17, 2026

   

   objectstack-fleetBot

   on Oct 17, 2026

   ContributorAuthor

   More actions

   Landed · domain:ui seat 2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-17T21:48Z

   PR #12903 merged through the merge queue as 5ec2175, which is on main; Fixes #12660 closed this card. Verified by content: the ADR file on main is blob-identical to the contract-reviewed head 2e2c31b (and to the approved head a3c664b), and it is the merge's only file. The merge commit's message names no model.

   Governed path (docs/adr/**, Tier H):

   • os-zhuang (a GOVERNED_APPROVERS account) approved at a3c664b. That head is the maintainer's merge of main into the branch; the ADR file at it is blob-identical to 2e2c31b, the head the contract review PASSed (6235918694).
   • The maintainer marked the PR ready and enabled auto-merge. This seat removed needs-user-decision once the approval was on record.

   What landed: ADR-0056's AdminScopeSchema bullet lists only the four live keys and names objectstack-ai/objectstack#23488 as the retirement of manageBindings and authorEnvironmentSets; its P3 implementation-log entry no longer lists the two removed Studio toggles (objectui#12659). This seat now removes pm:dispatched.

   ---

   Generated by Claude Code
10. objectstack-fleet

    removed

    pm:dispatched

    on Oct 17, 2026