Skip to content

docs(adr): mark ADR-0086's three ADR-0094 D5 pointers as retired, pointing at D5-R - #8385

Merged
hotlong merged 1 commit into
mainfrom
claude/issue-8292-adr-0086-retired-d5
Aug 13, 2026
Merged

docs(adr): mark ADR-0086's three ADR-0094 D5 pointers as retired, pointing at D5-R#8385
hotlong merged 1 commit into
mainfrom
claude/issue-8292-adr-0086-retired-d5

Conversation

@qq9340100

Copy link
Copy Markdown
Collaborator

Part of #8292

PR 2 of 2 — the ADR-class half. Deliberately does not share a diff with the customer-facing PR (#8384), so that one can land on the normal path; a mixed diff would route both to maintainer-only landing. This PR stays draft for the maintainer to merge — nothing is armed. #8292 remains open until both land.

The defect

ADR-0086 carried live-voiced, present-tense pointers at ADR-0094 D5's 2026-07-14 direction — an env overlay of a package-owned permission set is a first-class ADR-0005 customization — which was RETIRED on 2026-08-09 by D5-R (#6858 / PR #6962), after #6483 / PR #6608 rolled permission back to allowOrgOverride: false. Same defect class PR #8291 fixed inside ADR-0094's own D2, one document over; this follows that PR's idiom.

Three sites, not the one the card named

The card named the superseded-mechanisms block. Grepping ADR-0094 D5 across the file found four citations; three assert the retired channel:

Line Text Verdict
:380 D7 status row "an env edit of a package set is now a first-class overlay, not a flat 403" inverted — fixed
:383 P2 status row "Subtract layer landed as ADR-0005 first-class overlay (ADR-0094 D5)" stale — fixed
:400 superseded-mechanisms item 2 "ADR-0094 D5 (revised 2026-07-14) makes … a first-class ADR-0005 customization" the card's site — fixed
:377 D4 status row composition anchored at the position, ADR-0094 D5 left alone — D5-R does not withdraw that bullet

:380 was arguably worse than the site the card named: it asserts "not a flat 403" against a platform that now answers exactly that.

Each fixed site names D5-R, marks the direction retired, and records the upshot that matters for this ADR: its own two-doors answer stands unsuperseded — customize a packaged set by editing the package and re-publishing. The narrow carry-overs D5-R preserves are stated so they are not mistaken for a re-route: a data-door "delete" still degrades to a reset, and supportsOverlay: true is unchanged, so a pre-rollback overlay row still merges overlay-wins at read time (legacy state for an operator to lift, not a channel).

Per PR #8291's precedent, the historical record is kept as history, not rewritten.

Verification

Gates re-derived against the actual changed path with node scripts/pm/dispatch-gates.mjs — identical to the dispatch list, no delta.

  • pnpm check:adr-anchors — 48 anchored files, 120 decision numbers, 23447 citations resolve
  • node scripts/check-adr-links.mjs — 533 relative link destinations under docs/adr/ resolve
  • pnpm check:nul-bytes — 7589 files, no raw control bytes
  • node scripts/check-adr-merge-approval.mjs — locally it reaches its docs/adr/** path as expected and then fails on HTTP 401 Bad credentials (no token in the dev container); CI judges it with real credentials. The PR stays draft for the maintainer regardless, which is what this gate exists to enforce.

Docs-only ⇒ skip-changeset.


Generated by Claude Code

…nting at D5-R (#8292)

ADR-0086 carried three live-voiced, present-tense pointers at ADR-0094 D5's
2026-07-14 direction (an env overlay of a package-owned permission set is a
first-class ADR-0005 customization), which was RETIRED on 2026-08-09 by D5-R
(#6858 / PR #6962) after #6483 / PR #6608 rolled `permission` back to
`allowOrgOverride: false`:

- D7 status row: "an env edit of a package set is now a first-class overlay,
  not a flat 403" — directly contradicted by the current 403 not_overridable.
- P2 status row: "Subtract layer landed as ADR-0005 first-class overlay".
- The superseded-mechanisms block, item 2 (the site named in #8292).

Each now names D5-R and marks the direction retired, following the idiom
PR #8291 used inside ADR-0094 D2. The upshot is recorded where it matters:
this ADR's own two-doors answer stands unsuperseded — edit the package and
re-publish. The narrow carry-overs D5-R preserves (data-door delete still
degrades to a reset; supportsOverlay unchanged, so a pre-rollback overlay row
still merges at read time) are stated so they are not mistaken for a re-route.

The historical record is deliberately kept as history, not rewritten.

A fourth D5 citation (D4 status row, composition anchored at the position) is
left untouched: D5-R does not withdraw that bullet.

Part of #8292

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jqe56GnYFddggeAyfkZFVz
@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectstack Ignored Ignored Aug 13, 2026 10:47am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/s skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants